Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format numbers as text #9

Open
dselman opened this issue Jul 20, 2023 · 5 comments
Open

Format numbers as text #9

dselman opened this issue Jul 20, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@dselman
Copy link
Contributor

dselman commented Jul 20, 2023

Some clauses include text, such as:

within thirty (30) days for new acquisitions or creations where turnover exceeds GBP 10,000,000 or fifteen percent (15%) of total group turnover declared at inception of this Policy, whichever is the greater;

Where the numeric value and its text representation need to be kept in sync.

A formatting instruction for numbers could be added to covert the number to a locale specific string.

@dselman dselman added the enhancement New feature or request label Jul 20, 2023
@DevanceJ
Copy link

DevanceJ commented Mar 4, 2024

Hey I would like to work on this issue. Also, I'd like to participate in GSOC with the Accord Project, will it improve my chances if I solve a few issues in this repository? Specifically, i'd like to work on this project - https://github.com/accordproject/techdocs/wiki/Google-Summer-of-Code-2024-Ideas-List#1-playground-and-getting-started-experience

@ahmad-kashkoush
Copy link

Hi @dselman ,I've explored this repo locally and didn't figure out where should I implement the converter Functions, is the converter logic should be implemented here or in another repo?

@dselman
Copy link
Contributor Author

dselman commented Mar 6, 2024

The code would be an enhancement to the various "drafters" we have. E.g. here is the one for Integer:
https://github.com/accordproject/template-engine/tree/main/src/drafting/Integer

@ahmad-kashkoush
Copy link

ahmad-kashkoush commented Mar 7, 2024

@dselman It seems that this issue involves adding a formatting method that converts integer, long, and double values to English text. This formatting method gets called based on the format parameter in drafters.

Is my interpretation correct?
May I be assigned to this issue?

@ahmad-kashkoush
Copy link

ahmad-kashkoush commented Mar 8, 2024

@dselman I've created a PR that solve this Issue may I get a Review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants