Cicero UI -> Web Components #354

rutvi18 · 2021-03-22T09:47:13Z

Closes #301

Changes

Added the image in the overview page
Updated the link in started-resources.md

Screenshots or Video

Author Checklist

Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
Vital features and changes captured in unit and/or integration tests
Commits messages follow AP format
Merging to master from fork:Issue#301
Manual accessibility test performed
- Keyboard-only access, including forms
- Contrast at least WCAG Level A
- Appropriate labels, alt text, and instructions

docs/started-resources.md

Aniruddha-Shriwant · 2021-03-22T17:08:12Z

docs/ref-web-components-overview.md

+
+You can preview these components in [the project's storybook](https://ap-web-components.netlify.app/).
+
+![Template-Studio-V2](/docs/assets/reference/tsv2.png)


Although I'm not a maintainer I apologize for commenting here but, do we need this image which is of template-studio-v2 (which is archived now)?
Link of this PR preview build : https://deploy-preview-354--accordproject-old.netlify.app/docs/next/ref-web-components-overview.html

Yeah..I need to update the image!!

I think we don't really need an image here at the moment, so this could be removed.

jolanglinais · 2021-03-22T19:03:04Z

docs/started-resources.md

+### User Interface Components
+
+- [Markdown Editor](https://github.com/accordproject/web-components/tree/master/packages/ui-markdown-editor): a general purpose react component for markdown rendering and editing
+- [Cicero UI](https://docs.accordproject.org/docs/ref-cicero-ui.html): a library of react components for visualizing, creating and editing Accord Project templates


"Cicero UI" does not exist anymore, so I think we want to remove this reference and expand on what currently exists in web-components

jolanglinais

You'll want to ensure you provide a DCO sign-off for your commits using the --signoff option of git commit. This will require a rebase, in which you can reword your commit messages to follow the AP format

jolanglinais

Can you remove docs/assets/reference/sb.png?

jolanglinais · 2021-03-29T13:19:35Z

docs/started-resources.md

+### User Interface Components
+
+- [Markdown Editor](https://github.com/accordproject/web-components/tree/master/packages/ui-markdown-editor): a general purpose react component for markdown rendering and editing
+- [Contract Editor](https://github.com/accordproject/web-components/tree/master/packages/ui-contract-editor):provides a rich-text content editor for contract text with embedded clauses.


Can you make this:

[Contract Editor](https://github.com/accordproject/web-components/tree/master/packages/ui-contract-editor): a rich-text content editor for contract text with embedded clauses.

Do you mean to change the content or develop the page?

rutvi18 · 2021-03-29T15:32:03Z

I am getting this error while signing off. Can u help me understand what can be the reason?

Signed-off-by: Aniruddha Shriwant <[email protected]> Signed-off-by: My Name <[email protected]>

Cronus1007

@rutvi18 Here first of all make a git pull origin issue#301 and then use the command.It will work fine.

Signed-off-by: Aniruddha Shriwant <[email protected]> Signed-off-by: My Name <[email protected]>

Signed-off-by: My Name <[email protected]>

Signed-off-by : Rutvi Sharma <[email protected]> Signed-off-by: My Name <[email protected]>

Signed-off-by: Rutvi Sharma <[email protected]> Signed-off-by: My Name <[email protected]>

Signed-off-by: Rutvi Sharma Signed-off-by: My Name <[email protected]>

Signed-off-by: Rutvi Sharma [email protected] Signed-off-by: My Name <[email protected]>

Signed-off-by: My Name <[email protected]>

Aniruddha-Shriwant · 2021-03-29T17:24:43Z

Hey @rutvi18,
I was having the same DCO error before...I had tried this:
git commit --amend --signoff and and git push origin branchName --force this had worked for me, you can give it a try...
reference : https://stackoverflow.com/questions/13043357/git-sign-off-previous-commits

jolanglinais · 2021-03-30T15:41:17Z

Since this change is really small, could you rebase the 26 commits down to 1 commit please? You can then also ensure you provide a DCO sign-off for your commits using the --signoff option of git commit, as well as rewording your commit messages to follow the AP format.

author My Name <[email protected]> 1617033576 +0530 committer My Name <[email protected]> 1617121228 +0530 parent e4a788b author My Name <[email protected]> 1617033576 +0530 committer My Name <[email protected]> 1617121227 +0530 parent e4a788b author My Name <[email protected]> 1617033576 +0530 committer My Name <[email protected]> 1617121224 +0530 changes_done Signed-off-by: My Name <[email protected]> Updated the started-resources.md Signed-off-by : Rutvi Sharma <[email protected]> Signed-off-by: My Name <[email protected]> Updated the page Signed-off-by: Rutvi Sharma <[email protected]> Signed-off-by: My Name <[email protected]> Updated picture Signed-off-by: Rutvi Sharma Signed-off-by: My Name <[email protected]> image removed Signed-off-by: My Name <[email protected]> deleted the image Update started-resources.md Signed-off-by: My Name <[email protected]>

jeromesimeon · 2021-06-16T14:57:42Z

@rutvi18 any update on this?

Aniruddha-Shriwant reviewed Mar 22, 2021

View reviewed changes

docs/started-resources.md Outdated Show resolved Hide resolved

Aniruddha-Shriwant reviewed Mar 22, 2021

View reviewed changes

jolanglinais linked an issue Mar 22, 2021 that may be closed by this pull request

Cicero UI -> Web Components #301

Open

jolanglinais reviewed Mar 22, 2021

View reviewed changes

jolanglinais suggested changes Mar 22, 2021

View reviewed changes

rutvi18 force-pushed the issue#301 branch from 2058d58 to 5106eae Compare March 28, 2021 09:10

jolanglinais suggested changes Mar 29, 2021

View reviewed changes

fix(docs): modified text-accordproject#329

02747e4

Signed-off-by: Aniruddha Shriwant <[email protected]> Signed-off-by: My Name <[email protected]>

Cronus1007 reviewed Mar 29, 2021

View reviewed changes

Aniruddha-Shriwant and others added 11 commits March 29, 2021 21:30

fix(docs): updated broken link-accordproject#344

ff18e83

Signed-off-by: Aniruddha Shriwant <[email protected]> Signed-off-by: My Name <[email protected]>

updated docs/started-resources.md

654deee

Signed-off-by: My Name <[email protected]>

Updated the overview page

bb56c38

Signed-off-by: My Name <[email protected]>

Updated the started-resources.md

da22a4e

Signed-off-by : Rutvi Sharma <[email protected]> Signed-off-by: My Name <[email protected]>

Updated the page

a7fe33d

Signed-off-by: Rutvi Sharma <[email protected]> Signed-off-by: My Name <[email protected]>

Updated the link for Markdown-editor

9b275a7

Signed-off-by: Rutvi Sharma <[email protected]> Signed-off-by: My Name <[email protected]>

Updated picture

92db006

Signed-off-by: Rutvi Sharma Signed-off-by: My Name <[email protected]>

Added the pic

b52881a

Signed-off-by: Rutvi Sharma [email protected] Signed-off-by: My Name <[email protected]>

image removed

5bc56ba

Signed-off-by: My Name <[email protected]>

Changed the User interface Comp

421f7fb

Signed-off-by: My Name <[email protected]>

updated link

e4a788b

Signed-off-by: My Name <[email protected]>

rutvi18 force-pushed the issue#301 branch from 807f624 to ad60329 Compare March 30, 2021 16:37

rutvi18 force-pushed the issue#301 branch from ad60329 to 4928391 Compare March 30, 2021 16:39

mttrbrts closed this Nov 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cicero UI -> Web Components #354

Cicero UI -> Web Components #354

rutvi18 commented Mar 22, 2021 •

edited by jolanglinais

Loading

Aniruddha-Shriwant Mar 22, 2021

rutvi18 Mar 22, 2021

jolanglinais Mar 22, 2021

jolanglinais Mar 22, 2021

jolanglinais left a comment

jolanglinais left a comment

jolanglinais Mar 29, 2021

rutvi18 Mar 29, 2021

rutvi18 commented Mar 29, 2021

Cronus1007 left a comment •

edited

Loading

Aniruddha-Shriwant commented Mar 29, 2021 •

edited

Loading

jolanglinais commented Mar 30, 2021 •

edited

Loading

jeromesimeon commented Jun 16, 2021


		You can preview these components in [the project's storybook](https://ap-web-components.netlify.app/).

		![Template-Studio-V2](/docs/assets/reference/tsv2.png)

Cicero UI -> Web Components #354

Cicero UI -> Web Components #354

Conversation

rutvi18 commented Mar 22, 2021 • edited by jolanglinais Loading

Closes #301

Changes

Screenshots or Video

Author Checklist

Aniruddha-Shriwant Mar 22, 2021

Choose a reason for hiding this comment

rutvi18 Mar 22, 2021

Choose a reason for hiding this comment

jolanglinais Mar 22, 2021

Choose a reason for hiding this comment

jolanglinais Mar 22, 2021

Choose a reason for hiding this comment

jolanglinais left a comment

Choose a reason for hiding this comment

jolanglinais left a comment

Choose a reason for hiding this comment

jolanglinais Mar 29, 2021

Choose a reason for hiding this comment

rutvi18 Mar 29, 2021

Choose a reason for hiding this comment

rutvi18 commented Mar 29, 2021

Cronus1007 left a comment • edited Loading

Choose a reason for hiding this comment

Aniruddha-Shriwant commented Mar 29, 2021 • edited Loading

jolanglinais commented Mar 30, 2021 • edited Loading

jeromesimeon commented Jun 16, 2021

rutvi18 commented Mar 22, 2021 •

edited by jolanglinais

Loading

Cronus1007 left a comment •

edited

Loading

Aniruddha-Shriwant commented Mar 29, 2021 •

edited

Loading

jolanglinais commented Mar 30, 2021 •

edited

Loading