Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the transfomer(OOXML<->CiceroMark) #451

Open
4 tasks
K-Kumar-01 opened this issue Aug 17, 2021 · 0 comments
Open
4 tasks

Refactor the transfomer(OOXML<->CiceroMark) #451

K-Kumar-01 opened this issue Aug 17, 2021 · 0 comments
Labels
Difficulty: Challenging Type: Enhancement ✨ Improvement to process or efficiency

Comments

@K-Kumar-01
Copy link
Collaborator

K-Kumar-01 commented Aug 17, 2021

Discussion 🗣

Currently, the transformer for converting OOXML<->CiceroMark is quite big. The issue aims at dealing with refactoring it to reduce the size keeping the logic intact.

Context

Things to look at while refactoring:

  • More suitable naming for variables or functions
  • traverseNodes(): merge the 4th argument-parent properties into the properties argument and necessary changes in code for proper functioning. The reason being parent properties are generally used by nodes so they should be present in the properties itself.
  • generateTextOrCodeOOXML(): merge the 4th argument-parent properties into the properties argument and necessary changes in code for proper functioning. Same reason as above.
  • The tests currently for markdown-docx in algo-ooxml branch are uglified. Prettify all the tests.

Any other thing that can be refactored.

Detailed Description

The need for this issue arose during PR #441. Due to lack of time, the current implementation was done to launch a working transformer.

@jolanglinais jolanglinais added Difficulty: Challenging Type: Enhancement ✨ Improvement to process or efficiency labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Challenging Type: Enhancement ✨ Improvement to process or efficiency
Projects
None yet
Development

No branches or pull requests

2 participants