Type definitions for DCS

[sanketshevkar]

Bug Report 🐛

Type definitions for a DCS model are missing. Add generated typescript types of DCS Concerto Model to concerto-types module.

Expected Behavior

Type of DCS object should be centrally defined in concerto-types.

Possible Solution

We'll require a code generation script similar to this that will convert the DCS concerto model to its corresponding typescript definitions.

[Ayush1404]

Hi @sanketshevkar,

I hope you're doing well! I'm interested in contributing, but I'm having a bit of trouble understanding the issue. Could you kindly provide a bit more detail or clarify it for me?

Thanks so much in advance!

[sanketshevkar]

Hi @Ayush1404
I've updated the issue description with some reference link.

[Ayush1404]

@sanketshevkar thank you , i will look into it

[sanketshevkar]

@Ayush1404 just a heads up, I might pick this up next week on Wednesday, if not already started. Please let me know if you'd already started work on this.

[Ayush1404]

hey @sanketshevkar , sorry for the late reply , was a little busy due to college exams . We can do two things we can make changes in existing code-gen script to include DCS_MODEL from the decoratormanager.js file like this

or we can generate a new script , something like this

what do you think , which one do you think should we go for ?

[sanketshevkar]

Thanks @Ayush1404. I'm sorry I don't want to bother you during your exams, hope you are done with them.

The first approach seems fit to to me.

[Ayush1404]

@sanketshevkar No problem , the exams are over now . Do i have to make any changes in it , before making a PR ?

[sanketshevkar]

Idts, maybe just raise the PR following our contributors guideline and do not forget the DCO-Signoff :)