Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria/application_role #203

Closed
Malvoz opened this issue Dec 4, 2021 · 2 comments
Closed

aria/application_role #203

Malvoz opened this issue Dec 4, 2021 · 2 comments

Comments

@Malvoz
Copy link
Contributor

Malvoz commented Dec 4, 2021

https://a11ysupport.io/tech/aria/application_role

role="application" does not work as expected using Narrator on Windows 10 (no idea of where to find the version of Narrator I'm using) in Chrome v.96.0.4664.45.

Filed a bug: https://answers.microsoft.com/en-us/windows/forum/windows_11-wintop_apps-win_subtopwinapps/bug-narrator-ignores-aria-roleapplication/1252f6ff-ac41-4dd6-9b71-418b6eca40de (and in the Windows Feedback Hub: https://aka.ms/AAf1z86).

@scottaohara
Copy link
Contributor

scottaohara commented Dec 4, 2021

a few things here:

  1. the application role is announced with Narrator.
    • An aside: Reviewing the markup it seemed odd that you have role=appliation on a parent container rather than the element with role=region that is focused as its first child. That seems unnecessary as in application mode the navigating by landmarks / other quick keys will be disabled anyway, so not sure what value there is for having a landmark within the application, instead of allowing the role=application itself to receive focus? Outside of this demo, i could see a landmark used around the application to allow quick navigation to it.
  2. if i turn off scan mode, it works as you're expecting. are you thinking that Narrator just automatically change to forms/application mode when navigating into or to an element with role=application (e.g., behave like jaws/nvda in their default mode)? That's not the default setting for narrator. If you're in scan mode and navigate to a radio button, for example, it stays in scan mode. You have to press ins + space to go into application/forms mode.

@Malvoz
Copy link
Contributor Author

Malvoz commented Dec 4, 2021

Reviewing the markup it seemed odd that you have role=appliation on a parent container rather than the element with role=region that is focused as its first child.

Initially we were only using role=region on the focusable container, we're trying to make pan and zoom meaningful to screen reader users by announcing movement (partial solution) so role=application is desirable, however simply replacing region with application on the focusable container resulted in "application" not being announced in NVDA which I thought was important to the user. That's perhaps a shadow DOM issue with NVDA? I'll revisit the roles and see if we can improve.

It certainly seems problematic to not have <mapml-viewer> wrapper be the focusable element, not sure we can do anything about that without breaking the wrapped LeafletJS component though.

are you thinking that Narrator just automatically change to forms/application mode when navigating into or to an element with role=application (e.g., behave like jaws/nvda in their default mode)? That's not the default setting for narrator.

Yes, it didn't occur to me that Narrator could've just chosen to behave differently 😅, I'll withdraw my bug reports.
Thank you @scottaohara.

@Malvoz Malvoz closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants