Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep audio file info when file is missing #325

Open
robbevp opened this issue Apr 22, 2022 · 0 comments
Open

Keep audio file info when file is missing #325

robbevp opened this issue Apr 22, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@robbevp
Copy link
Member

robbevp commented Apr 22, 2022

When a file is missing during a rescan, we currently delete the audio_file instance and add a warning to the rescan log.

The information about an audio file (mostly: location and filename) can still be relevant after a file goes missing, for example to figure out what happened to a file.
Once the rescan has run again, the mod+ has no way of figuring out what the filename and location was.

Reproduction steps
  1. Add track and audio file
  2. Remove audio file from system
  3. Run rescan twice
  4. Try and figure out where the track's audio file was located
Expected behaviour

We should keep this info so users can debug missing file easily. It should be marked as 'missing' is some way.
Only once the track is deleted or merged should the audio_file instance be deleted

@robbevp robbevp added the bug Something isn't working label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant