You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For the updated favicon choice: I would suggest using https://commons.wikimedia.org/wiki/File:OOjs_UI_icon_academic-progressive.svg , which comes with a blue icon that is visible both in dark theme and light theme. Its icon license is CC0-1.0, means that we can directly use it without any copyright concerns.
The text was updated successfully, but these errors were encountered:
As discussed in academicpages#1181, I suggest to make embedding videos an optional
feature.
This behavior aligns well with recently merged PR academicpages#2312.
Open questions:
1. I added a youtube link to `papers.bib`. Is this link okay?
2. I set `enable_video_embedding: false` as the default. I argue that
privacy settings should be the default. Also, the current implementation
of `video.liquid` only works for some very specific video URLs. For
example, to embed youtube, specialized links must be used to avoid
`X-Frame-Option` issues. This behavior can lead to a broken embedding,
which would not look very nice.
Feedback welcome.
Problems
I noticed the aging code around the handling of favicon in the theme. To be more concrete:
The
QUERY_STRING
here is suspicious. Those two icons also never existed anywhere._includes/head/custom/html
mentionedmsapplication-*
<meta>
tags, which I believe are deprecated./images/manifest.json
mentions a lot of icons that do not exist at all._includes/head/custom.html
linked tosafari-pinned-tab.svg
, which is not the same as our expected favicon.favicon.ico
is mostly black, which is invisible when dark theme is enabled.Possible Solutions
I found the valuable blog article https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs , which should describe the best practice in handling favicon.
For the updated favicon choice: I would suggest using https://commons.wikimedia.org/wiki/File:OOjs_UI_icon_academic-progressive.svg , which comes with a blue icon that is visible both in dark theme and light theme. Its icon license is
CC0-1.0
, means that we can directly use it without any copyright concerns.The text was updated successfully, but these errors were encountered: