Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon revised: Prepare dark-theme-friendly favicon, make it 404-free, modern favicon handling #2337

Open
hosiet opened this issue Aug 17, 2024 · 0 comments
Labels
enhancement An enhancement.
Milestone

Comments

@hosiet
Copy link

hosiet commented Aug 17, 2024

Problems

I noticed the aging code around the handling of favicon in the theme. To be more concrete:

  • For each site deployed, there are always two 404 error appearing:
GET $HOST/images/android-chrome-192x192.png?v=M44lzPylqQ NS_ERROR_FAILURE
GET $HOST/images/favicon-32x32.png?v=M44lzPylqQ NS_ERROR_FAILURE

The QUERY_STRING here is suspicious. Those two icons also never existed anywhere.

  • _includes/head/custom/html mentioned msapplication-* <meta> tags, which I believe are deprecated.
  • /images/manifest.json mentions a lot of icons that do not exist at all.
  • _includes/head/custom.html linked to safari-pinned-tab.svg, which is not the same as our expected favicon.
  • The current favicon.ico is mostly black, which is invisible when dark theme is enabled.

Possible Solutions

I found the valuable blog article https://evilmartians.com/chronicles/how-to-favicon-in-2021-six-files-that-fit-most-needs , which should describe the best practice in handling favicon.

For the updated favicon choice: I would suggest using https://commons.wikimedia.org/wiki/File:OOjs_UI_icon_academic-progressive.svg , which comes with a blue icon that is visible both in dark theme and light theme. Its icon license is CC0-1.0, means that we can directly use it without any copyright concerns.

@rjzupkoii rjzupkoii added the enhancement An enhancement. label Aug 17, 2024
@rjzupkoii rjzupkoii added this to the v0.9 milestone Aug 17, 2024
karinavasudeva pushed a commit to karinavasudeva/karinavasudeva.github.io that referenced this issue Sep 6, 2024
As discussed in academicpages#1181, I suggest to make embedding videos an optional
feature.

This behavior aligns well with recently merged PR academicpages#2312.

Open questions:

1. I added a youtube link to `papers.bib`. Is this link okay?
2. I set `enable_video_embedding: false` as the default. I argue that
privacy settings should be the default. Also, the current implementation
of `video.liquid` only works for some very specific video URLs. For
example, to embed youtube, specialized links must be used to avoid
`X-Frame-Option` issues. This behavior can lead to a broken embedding,
which would not look very nice.

Feedback welcome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants