Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix format variable #83

Open
cg-cnu opened this issue Oct 13, 2017 · 2 comments
Open

fix format variable #83

cg-cnu opened this issue Oct 13, 2017 · 2 comments

Comments

@cg-cnu
Copy link

cg-cnu commented Oct 13, 2017

A variable format is used which is a reserved keyword in python.
Change that to something like output_format.
Fixed the issue but need to test out, will do a pr soon! 😄

@cg-cnu cg-cnu changed the title fix format varible fix format variable Oct 13, 2017
@mottosso
Copy link
Member

I wouldn't be too fussed about this particular use, partly because it's originally one from cmds.playblast(format="") but also because the function referenced by the keyword isn't used in the scope within which it is being used.

In general, if shadowing a keyword improves overall readability, I think it's ok. Put another way, if adhering to PEP08 reduces readability, then I'd say it's safe to ignore the particular warning.

@cg-cnu
Copy link
Author

cg-cnu commented Oct 13, 2017

I agree with you, that's why I left it in the initial pr. Since we are planning for pylinting on travis, thought this might error out. I am not sure if we can tune the pylinter to ignore this case 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants