Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCIO: Resolve npm dependencies based on lockfiles #1237

Closed
1 task done
pombredanne opened this issue May 16, 2024 · 1 comment
Closed
1 task done

SCIO: Resolve npm dependencies based on lockfiles #1237

pombredanne opened this issue May 16, 2024 · 1 comment
Assignees

Comments

@pombredanne
Copy link
Member

pombredanne commented May 16, 2024

I would like to have a pipeline (likely an addon pipeline) that can resolve the dependencies given this context:

We also need the same elsewhere:

@pombredanne pombredanne changed the title Resolve npm dependencies based on lockfiles SCIO: Resolve npm dependencies based on lockfiles May 16, 2024
AyanSinhaMahapatra added a commit that referenced this issue May 22, 2024
Reference: #1237
Reference: #1066
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra added a commit that referenced this issue Jun 13, 2024
Reference: #1237
Reference: #1066
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
AyanSinhaMahapatra added a commit that referenced this issue Jun 17, 2024
Resolves dependency for cases where multiple requirements
are resolved by one package and all the version requirements
are joined for that package.

Reference: #1237
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
tdruez pushed a commit that referenced this issue Jul 1, 2024
* Resolve dependencies from lockfiles #1237

Reference: #1237
Reference: #1066
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

* Address feedback and add improvements

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

* Improve dependency resolving from lockfiles #1237

Resolves dependency for cases where multiple requirements
are resolved by one package and all the version requirements
are joined for that package.

Reference: #1237
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

* Update scancode-toolkit and fix tests

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

* Bump scancode-toolkit to v32.2.0

Reference: https://github.com/nexB/scancode-toolkit/releases/tag/v32.2.0
Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

* Regenerate test fixtures and expectations

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

* Improve dependency resolver for lockfiles

Handle various lockfile cases where:
* Same package/dependencies are present in different lockfiles
* Independent lockfiles without a manifest and root package
* Ecosystems which have only a single version of package in
  their environment
* Dependency graphs where a resolved package can have many
  parent packages.

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

* Address feedback and refactor code

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

* FIx bugs for resolving python packages

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

* Add unit tests and refactor code

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

* Address comments and add CHANGELOG entries

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>

---------

Signed-off-by: Ayan Sinha Mahapatra <[email protected]>
@AyanSinhaMahapatra
Copy link
Member

This is completed in #1244, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants