Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display warning when a "download_url" could not be generated from PURL in "Add Package" #163

Closed
tdruez opened this issue Aug 7, 2024 · 0 comments
Closed

Display warning when a "download_url" could not be generated from PURL in "Add Package" #163

tdruez opened this issue Aug 7, 2024 · 0 comments
Labels
design needed Design details needed to complete the issue enhancement New feature or request

Comments

@tdruez
Copy link
Contributor

tdruez commented Aug 7, 2024 •
edited
Loading

We recently added support for providing a PURL as the input of "Add Package" as an alternative to a download_url.
#131

When a PURL is provided, the purl2url is called to get a download_url but it cannot be done for all types of PURL.

The UI should be explicit about letting know the user that a download URL couldn't be generated and the consequences of it.

Related discussion:
@tdruez tdruez added enhancement New feature or request design needed Design details needed to complete the issue labels Aug 7, 2024
tdruez added a commit that referenced this issue Aug 22, 2024
@tdruez
Display warning when a "download_url" could not be determined from a …
939ca39 
…PURL #163

Signed-off-by: tdruez <[email protected]>
@tdruez tdruez mentioned this issue Aug 22, 2024
Merged
tdruez added a commit that referenced this issue Aug 22, 2024
@tdruez
Display warning when a "download_url" could not be determined from a …
2fdfb5c 
…PURL #163 (#170)

Signed-off-by: tdruez <[email protected]>
@tdruez tdruez closed this as completed Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design needed Design details needed to complete the issue enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tdruez