From a843ac175b86d0f3fdc4f5e563559d2a2c9aed9f Mon Sep 17 00:00:00 2001
From: Moritz Mock <mock.moritz@rolmail.net>
Date: Thu, 30 Sep 2021 13:31:36 +0200
Subject: [PATCH 1/2] removed React.forwardRef from SelectItem Component

---
 src/components/form/async/SelectItem.tsx | 229 ++++++++++-------------
 1 file changed, 102 insertions(+), 127 deletions(-)

diff --git a/src/components/form/async/SelectItem.tsx b/src/components/form/async/SelectItem.tsx
index 9f00798d..e2e1db56 100644
--- a/src/components/form/async/SelectItem.tsx
+++ b/src/components/form/async/SelectItem.tsx
@@ -1,11 +1,10 @@
-import React, { useMemo, useState } from 'react'
+import React, { ReactElement, useMemo, useState } from 'react'
 import { useField } from 'formik'
 import classnames from 'classnames'
 import IconKeyboardArrowDown from '@aboutbits/react-material-icons/dist/IconKeyboardArrowDown'
 import IconClose from '@aboutbits/react-material-icons/dist/IconClose'
-
-import { useInternationalization } from '../../../framework'
 import { useCustomInputCss } from '../useCustomInputCss'
+import { useInternationalization } from '../../../framework'
 import { InputLabel } from '../InputLabel'
 import { InputError } from '../InputError'
 import {
@@ -13,26 +12,23 @@ import {
   Props as DialogProps,
 } from './SelectItemDialogWithSearch'
 
-type Props<ItemType extends ReferenceObject, Error> = React.DetailedHTMLProps<
-  React.ButtonHTMLAttributes<HTMLButtonElement>,
-  HTMLButtonElement
-> & {
+type Props<ItemType extends ReferenceObject, Error> = {
+  disabled?: boolean
   id: string
   name: string
   label: string
   placeholder: string
-  disabled?: boolean
   defaultValue: ItemType
 } & Pick<
-    DialogProps<ItemType, Error>,
-    | 'useGetData'
-    | 'dialogTitle'
-    | 'dialogLabel'
-    | 'noSearchResults'
-    | 'renderListItem'
-    | 'renderErrorMessage'
-    | 'paginationConfig'
-  >
+  DialogProps<ItemType, Error>,
+  | 'useGetData'
+  | 'dialogTitle'
+  | 'dialogLabel'
+  | 'noSearchResults'
+  | 'renderListItem'
+  | 'renderErrorMessage'
+  | 'paginationConfig'
+>
 
 export type ReferenceObject = {
   id: string | number
@@ -40,8 +36,6 @@ export type ReferenceObject = {
   label?: string
 }
 
-type ItemType = ReferenceObject
-
 /**
  * Converts tailwindcss classes from placeholder to text.
  *
@@ -70,120 +64,101 @@ export const replacePlaceholderColorWithTextColor = (css: string): string => {
   )
 }
 
-export const SelectItem = React.forwardRef<
-  HTMLButtonElement,
-  Props<ItemType, Error>
->(
-  (
-    {
-      disabled = false,
-      id,
-      name,
-      label,
-      placeholder,
-      defaultValue,
-      useGetData,
-      dialogTitle,
-      dialogLabel,
-      noSearchResults,
-      renderListItem,
-      renderErrorMessage,
-      paginationConfig,
-    },
-    ref
-  ) => {
-    const [field, , helpers] = useField<ItemType>(name)
-    const [, , helpersId] = useField<ItemType>(name + '.id')
-    const [showDialog, setShowDialog] = useState<boolean>(false)
-    const customCss = useCustomInputCss(`${field.name}.id`, disabled)
-    const internationalization = useInternationalization()
-    const customCssInputCss = useMemo(
-      () => replacePlaceholderColorWithTextColor(customCss.inputCss),
-      [customCss.inputCss]
-    )
+export function SelectItem<ItemType extends ReferenceObject, Error>({
+  disabled = false,
+  id,
+  name,
+  label,
+  placeholder,
+  defaultValue,
+  useGetData,
+  dialogTitle,
+  dialogLabel,
+  noSearchResults,
+  renderListItem,
+  renderErrorMessage,
+  paginationConfig,
+}: Props<ItemType, Error>): ReactElement {
+  const [field, , helpers] = useField<ItemType>(name)
+  const [, , helpersId] = useField<ItemType>(name + '.id')
+  const [showDialog, setShowDialog] = useState<boolean>(false)
+  const customCss = useCustomInputCss(`${field.name}.id`, disabled)
+  const internationalization = useInternationalization()
+  const customCssInputCss = useMemo(
+    () => replacePlaceholderColorWithTextColor(customCss.inputCss),
+    [customCss.inputCss]
+  )
 
-    return (
-      <>
-        <div>
-          <InputLabel
-            inputId={id}
-            label={label}
-            className={customCss.labelCss}
-          />
-          {field.value.id === '' || field.value.id === 0 ? (
+  return (
+    <>
+      <div>
+        <InputLabel inputId={id} label={label} className={customCss.labelCss} />
+        {field.value.id === '' || field.value.id === 0 ? (
+          <button
+            type="button"
+            id={id}
+            onClick={() => {
+              setShowDialog(true)
+            }}
+            className={classnames(customCssInputCss, 'flex flex-row text-left')}
+          >
+            <span className="flex-1">{placeholder}</span>
+            <IconKeyboardArrowDown className="w-6 h-6" />
+          </button>
+        ) : (
+          <div
+            className={classnames(
+              customCss.inputCss,
+              'flex flex-row text-left'
+            )}
+          >
             <button
               type="button"
               id={id}
+              onClick={() => setShowDialog(true)}
+              className="flex-1 text-left"
+            >
+              <span>{field.value.name}</span>
+            </button>
+            <button
+              type="button"
               onClick={() => {
-                setShowDialog(true)
+                helpers.setTouched(true)
+                helpersId.setTouched(true)
+                helpers.setValue(defaultValue)
               }}
-              className={classnames(
-                customCssInputCss,
-                'flex flex-row text-left'
-              )}
-              {...ref}
+              className="pl-2"
             >
-              <span className="flex-1">{placeholder}</span>
-              <IconKeyboardArrowDown className="w-6 h-6" />
+              <IconClose
+                className="w-6 h-6"
+                title={internationalization.translate('shared.select.clear')}
+              />
             </button>
-          ) : (
-            <div
-              className={classnames(
-                customCss.inputCss,
-                'flex flex-row text-left'
-              )}
-            >
-              <button
-                type="button"
-                id={id}
-                onClick={() => setShowDialog(true)}
-                className="flex-1 text-left"
-                {...ref}
-              >
-                <span>{field.value.name}</span>
-              </button>
-              <button
-                type="button"
-                onClick={() => {
-                  helpers.setTouched(true)
-                  helpersId.setTouched(true)
-                  helpers.setValue(defaultValue)
-                }}
-                className="pl-2"
-              >
-                <IconClose
-                  className="w-6 h-6"
-                  title={internationalization.translate('shared.select.clear')}
-                />
-              </button>
-            </div>
-          )}
-          <InputError name={field.name + '.id'} className="mt-1" />
-        </div>
-        {showDialog && (
-          <SelectItemDialogWithSearch
-            onDismiss={() => {
-              helpersId.setTouched(true)
-              setShowDialog(false)
-            }}
-            isOpen={showDialog}
-            onConfirm={(item: ItemType) => {
-              helpersId.setTouched(true)
-              helpers.setValue(item)
-              setShowDialog(false)
-            }}
-            useGetData={useGetData}
-            renderListItem={renderListItem}
-            renderErrorMessage={renderErrorMessage}
-            dialogTitle={dialogTitle}
-            dialogLabel={dialogLabel}
-            noSearchResults={noSearchResults}
-            paginationConfig={paginationConfig}
-          />
+          </div>
         )}
-      </>
-    )
-  }
-)
-
-SelectItem.displayName = 'SelectItem'
+        <InputError name={field.name + '.id'} className="mt-1" />
+      </div>
+      {showDialog && (
+        <SelectItemDialogWithSearch
+          onDismiss={() => {
+            helpersId.setTouched(true)
+            setShowDialog(false)
+          }}
+          isOpen={showDialog}
+          onConfirm={(item: ItemType) => {
+            helpersId.setTouched(true)
+            helpers.setValue(item)
+            setShowDialog(false)
+          }}
+          useGetData={useGetData}
+          renderListItem={renderListItem}
+          renderErrorMessage={renderErrorMessage}
+          dialogTitle={dialogTitle}
+          dialogLabel={dialogLabel}
+          noSearchResults={noSearchResults}
+          paginationConfig={paginationConfig}
+        />
+      )}
+    </>
+  )
+}

From b99a08f2216e9c1e83aea5ca7cca74e3e8515809 Mon Sep 17 00:00:00 2001
From: Moritz Mock <mock.moritz@rolmail.net>
Date: Thu, 30 Sep 2021 13:33:51 +0200
Subject: [PATCH 2/2] adjusted ordering of parameters

---
 src/components/form/async/SelectItem.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/components/form/async/SelectItem.tsx b/src/components/form/async/SelectItem.tsx
index e2e1db56..fdcc3272 100644
--- a/src/components/form/async/SelectItem.tsx
+++ b/src/components/form/async/SelectItem.tsx
@@ -13,11 +13,11 @@ import {
 } from './SelectItemDialogWithSearch'
 
 type Props<ItemType extends ReferenceObject, Error> = {
-  disabled?: boolean
   id: string
   name: string
   label: string
   placeholder: string
+  disabled?: boolean
   defaultValue: ItemType
 } & Pick<
   DialogProps<ItemType, Error>,