Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to ESBuild from Babel #74

Open
id3vz opened this issue Aug 13, 2021 · 2 comments
Open

Migration to ESBuild from Babel #74

id3vz opened this issue Aug 13, 2021 · 2 comments
Labels
effort: med up to a week impact: med minor perf improvements, fix broad userbase issues topic: Performance type: question or discussion Issue discussing or asking a question

Comments

@id3vz
Copy link

id3vz commented Aug 13, 2021

I'm using the React + TypeScript branch and using React in ContentScript,
When I make any change in the react files it takes about 40 seconds until I can see the change in the browser and the page reloaded.
How to make it faster as 40 seconds is too much?
@abhijithvijayan

This comment has been minimized.

Sign in to view
@abhijithvijayan abhijithvijayan added effort: med up to a week impact: med minor perf improvements, fix broad userbase issues topic: Performance type: question or discussion Issue discussing or asking a question labels Aug 13, 2021
@abhijithvijayan abhijithvijayan changed the title Hot Reloading in contentscript Migration to ESBuild Aug 14, 2021
@abhijithvijayan abhijithvijayan changed the title Migration to ESBuild Migration to ESBuild from Babel Aug 14, 2021
@abhijithvijayan
Copy link
Owner

This is do-able but the problem could be with support for old browsers(as I am not sure if ESBuild is somewhat flexible to Babel's browser version specific bundles) So this could mean dropping support for older browsers.

Currently the manifest v3 upgrade might need to drop support for old browsers ( Chrome < 88 ). If that is the case, I will surely consider doing this too. For now I think Keeping Babel is fine. But if anyone needs it be be switched with Esbuild, there is a webpack loader for that, feel free to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: med up to a week impact: med minor perf improvements, fix broad userbase issues topic: Performance type: question or discussion Issue discussing or asking a question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abhijithvijayan @id3vz