Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to website by clicking on website name in the card detail #169

Open
The-Phoenics opened this issue Jul 24, 2024 · 9 comments
Open
Assignees

Comments

@The-Phoenics
Copy link

Is your feature request related to a problem? Please describe.
It would a better user experience if the user could navigate to the website by simply clicking on the website name in the website-password details card.

Describe the solution you'd like
We can make the element (that shows website name in the card) a anchor tag and redirect the user to that website when the user clicks that element.

anchor-tag

Copy link

Hi there! Thanks for opening this issue. We appreciate your contribution to this open-source project. We aim to respond or assign your issue as soon as possible.

@The-Phoenics
Copy link
Author

Hey @abhijeetnishal
Can you please take a look at this issue? I would like to work on this under GSSoC'24.

@abhijeetnishal
Copy link
Owner

Hey @The-Phoenics, we need to verify the website also right?
What if someone add incorrect url and if they redirect it will show error?
Will you verify the added url?

@The-Phoenics
Copy link
Author

Hey @abhijeetnishal
Yes we can do a check using fetch and resulting status codes. But I think it should be totally up to the user what they want their passwords to map to.

@abhijeetnishal
Copy link
Owner

Yes, it depends on users also. But still add the function to check.
Assigning this issue to you, good luck.

@The-Phoenics
Copy link
Author

The-Phoenics commented Jul 28, 2024

Hey @abhijeetnishal
I need your help in setting up the project locally.

This is my server's .env
2024-07-28_15-36

console:
problem

I could not find the /client/.env.sample which should pe pasted and configured in client/.env.local as mentioned in Application Setup section of readme

@abhijeetnishal
Copy link
Owner

abhijeetnishal commented Jul 28, 2024

Hey @The-Phoenics, the env for client is not correct I guess that's why the endpoint is incorrect. The filename for client is local.env and it contains NEXT_PUBLIC_BASE_URL=http://localhost:8080

I think somehow sample.env is not there I will fix that issue, sorry for that.

@The-Phoenics
Copy link
Author

Hey @abhijeetnishal
I've added local.env in the client directory, still unable to register
error-env

@abhijeetnishal
Copy link
Owner

abhijeetnishal commented Jul 28, 2024

Hey @The-Phoenics, Change the file name to .env.local from local.env and restart the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants