We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 0.4.8 fails to compile for AARCH64 / ARM64 due to the two x86 specific compiler flags in CMakeLists.txt: -mavx and -mfma.
CMakeLists.txt
-mavx
-mfma
CMakeLists.txt ideally needs to take into account architecture as well as platform.
The text was updated successfully, but these errors were encountered:
Suggest the following addition to the CMakeLists.txt to accommodate:
Currently the compiler flag options cover the following:
if(MSVC) SET(CMAKE_CXX_FLAGS "/EHsc /arch:AVX2") SET(CMAKE_CXX_FLAGS_DEBUG "/W4") elseif(DARWIN) SET(CMAKE_CXX_FLAGS "-Wno-int-in-bool-context -std=c++11") SET(CMAKE_CXX_FLAGS_DEBUG "-Wall") else() SET(CMAKE_CXX_FLAGS "-march=native -Wno-int-in-bool-context -std=c++11 -mavx -mfma") SET(CMAKE_CXX_FLAGS_DEBUG "-Wall") endif()
Suggest adding a further outcome to cover explicitly the aarch64 compilation and remove flags which cause built errors:
aarch64
elseif(CMAKE_SYSTEM_PROCESSOR STREQUAL "aarch64") SET(CMAKE_CXX_FLAGS "-march=native -Wno-int-in-bool-context -std=c++11") SET(CMAKE_CXX_FLAGS_DEBUG "-Wall")
I have tested this solution and it builds without issue on aarch64 machine.
Sorry, something went wrong.
Thank you @MattWenham and @ecm200 . We will take a look and update CMakeLists.txt accordingly soon.
oooo26
No branches or pull requests
Version 0.4.8 fails to compile for AARCH64 / ARM64 due to the two x86 specific compiler flags in
CMakeLists.txt
:-mavx
and-mfma
.CMakeLists.txt
ideally needs to take into account architecture as well as platform.The text was updated successfully, but these errors were encountered: