Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions workflow is unable to start rcedit #148

Open
OverloadedOrama opened this issue Aug 21, 2024 · 4 comments
Open

GitHub Actions workflow is unable to start rcedit #148

OverloadedOrama opened this issue Aug 21, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@OverloadedOrama
Copy link
Contributor

OverloadedOrama commented Aug 21, 2024

I'm getting this error when using godot-ci (Godot 4.3) to export a Windows build:
WARNING: Resources Modification: Could not start rcedit executable. Configure rcedit path in the Editor Settings (Export > Windows > rcedit), or disable "Application > Modify Resources" in the export preset.
Example run, on the Windows build step: https://github.com/Orama-Interactive/Pixelorama/actions/runs/10490990141/job/29058991598

Not sure if I need to setup anything myself extra, but because #146 is now merged, I am assuming I don't have to.

@Kiisu-Master
Copy link

~/.config/godot/editor_settings-4.tres
is now ~/.config/godot/editor_settings-4.3.tres and will change with every feature or major release.

@Calinou Calinou added the bug Something isn't working label Aug 22, 2024
@Kiisu-Master
Copy link

This probably also breaks the android part of the stuff.

I already dealt with this change on GodSVG exports ( custom github actions instead of this image ). I decided to just add a new argument for the Godot feature version, because I didn't want to try extracting the feature version from the full version. I don't know how this Docker stuff works and if it's possible to do the same here...

@Calinou
Copy link
Collaborator

Calinou commented Aug 22, 2024

I'm puzzled that 4.3-stable was tagged when the files within its tag still refer to 4.2.1.

@OverloadedOrama
Copy link
Contributor Author

I'm puzzled that 4.3-stable was tagged when the files within its tag still refer to 4.2.1.

That's because the release.yml workflow is updating the GODOT_VERSION argument

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants