Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move docker back to docker dir #96

Closed
sbcgua opened this issue Jul 12, 2020 · 5 comments · Fixed by #257
Closed

move docker back to docker dir #96

sbcgua opened this issue Jul 12, 2020 · 5 comments · Fixed by #257
Assignees

Comments

@sbcgua
Copy link
Collaborator

sbcgua commented Jul 12, 2020

revert #41 (and ensure it works :) ) and also adjust build.yml filters (as the repo name changed)

P.S. after current PRs are merged
P.P.S just in case "why": files at root levels makes it a bit cluttered, and may become more cluttered if more compose scenarios are introduced. E.g. abaplint+nginx+ssl certs

@sbcgua sbcgua self-assigned this Jul 12, 2020
@sbcgua
Copy link
Collaborator Author

sbcgua commented Jul 12, 2020

notes: jq '.dependencies."@abaplint/core".version' -r package-lock.json to extract version from package lock without installing all the deps

@larshp
Copy link
Member

larshp commented Jul 13, 2020

agree: should try to have less files at root level

@sbcgua
Copy link
Collaborator Author

sbcgua commented Jul 16, 2020

improve todo:

  • fix run/scripts
  • add build&run script
  • add cleanup script
  • maybe link them to npm scripts (not sure, mixing things) ???

@sbcgua sbcgua mentioned this issue Oct 3, 2020
@sbcgua
Copy link
Collaborator Author

sbcgua commented Oct 4, 2020

@larshp Are you using docker password or docker token as a secret ? Well, tokens are available now (I think it was not so before) - https://docs.docker.com/docker-hub/access-tokens/

@larshp
Copy link
Member

larshp commented Oct 4, 2020

tokens,

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants