Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker improvements #257

Merged
merged 9 commits into from
Oct 4, 2020
Merged

Docker improvements #257

merged 9 commits into from
Oct 4, 2020

Conversation

sbcgua
Copy link
Collaborator

@sbcgua sbcgua commented Oct 4, 2020

Closes: #96, Closes: #253, Closes: #256

OK, multiple changes here:

  1. renames in package.json :) There was still cloudforge name
  2. move docker files back to docker dir
  3. better scripts in bin, including new test and cleanup and reuse them in GA flow
  4. Better structure in GA flow, use version 2 of docker/build-push-action
  • test-js no meaningful changes
  • test-docker - just tests the build but no publish
  • publish-docker - dependent on success of test-docker, and if used just once on job level
  • run only on commit to master or PR to master (before it was for any commit anywhere)
  1. index.ts in the root => more consistent addressing from npm scripts and docker file
  2. Some docs on the new features. Ans also "CI check list" section as a reminder what to be checked if the CI flow is adjusted

CI flow tested on https://hub.docker.com/repository/docker/sbcgua/abaplint-backend-dev but leaves some room for potential mistake because of the refs change in last commit. But hopefully should work. See also https://github.com/sbcgua/abaplint-sci-server/runs/1205277789?check_suite_focus=true

@larshp
Copy link
Member

larshp commented Oct 4, 2020

thanks 👍

@larshp larshp merged commit 8ed6d3a into abaplint:master Oct 4, 2020
@sbcgua
Copy link
Collaborator Author

sbcgua commented Oct 4, 2020

Works 🎉

image

image

@sbcgua sbcgua deleted the docker-improvements branch October 4, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants