Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sbcgua more structure #24

Merged
merged 8 commits into from
Apr 4, 2020
Merged

Sbcgua more structure #24

merged 8 commits into from
Apr 4, 2020

Conversation

larshp
Copy link
Member

@larshp larshp commented Apr 4, 2020 •
edited
Loading

closes #2

closes #23

@larshp larshp mentioned this pull request Apr 4, 2020
Closed
@larshp
Copy link
Member Author

larshp commented Apr 4, 2020

@sbcgua can you take a look? can we merge this and work from there?

@sbcgua
Copy link
Collaborator

sbcgua commented Apr 4, 2020

I think yes, let do it.

I will check how to improve it somewhen later and taking into account CF. Maybe docker will unify both approaches but I need to read how CF works with docker. :)

@larshp larshp merged commit d9fd139 into master Apr 4, 2020
@larshp larshp deleted the sbcgua-more-structure branch April 4, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm test is broken in CI express setup
2 participants
@larshp @sbcgua