Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the rule that is causing the issue #42

Closed
ed-holland opened this issue Jun 29, 2020 · 8 comments
Closed

Show the rule that is causing the issue #42

ed-holland opened this issue Jun 29, 2020 · 8 comments
Assignees

Comments

@ed-holland
Copy link
Collaborator

In the message from SCI, the rule is not mentioned that was failing.
FUGR /JCS/BC > PROG LBTCHDEF [ @518 ] Variable "rc_tgt_host_chk_has_failed" not used, #JCS#BC.FUGR.LBTCHDEF.ABAP

like in the pipeline:
/tmp/abaplint-aigijg/src/cx_salv_bs_tools_conv_error.clas.abap[1, 1] - Expected CLASSDEFINITION (structure)

@larshp
Copy link
Member

larshp commented Jun 29, 2020

where is the first text from?

also see abaplint/abaplint-sci-server#21

image

@ed-holland
Copy link
Collaborator Author

We might want to use an other field for the information. We are using the inform method:
image

It contains 4 attribute parameters (only one is used). Or embed it in the message (at the end in round brackets).

Reference

@larshp
Copy link
Member

larshp commented Jun 29, 2020

yea, so embed the abaplint key as last thing in the message text

and then we can hash the message code to SCI_ERRC in order to have the correct grouping

@larshp
Copy link
Member

larshp commented Jun 30, 2020

try again, latest version of the abap code

@ed-holland
Copy link
Collaborator Author

using the latest change (also on docker) shows the rule.
Would propose though to change to p_text = '&1 (&2)'. which makes it the same as with abaplint and is also more visible.

When running SCI using ADT the message seems to be messed up
image

@ed-holland
Copy link
Collaborator Author

ed-holland commented Jun 30, 2020

Had a case where the message is getting to long.
image

Would it not be better to remove the file path? or put it at the end or a new line? or as hover-text over the url.

larshp added a commit that referenced this issue Jul 1, 2020
@larshp
Copy link
Member

larshp commented Jul 1, 2020

ATC? please move that to a separate issue

description fixed in 765693d

idea is to only output the filename in some cases, it now handles namespaces, b57c0fb

@ed-holland
Copy link
Collaborator Author

Much better. Thanks

ed-holland pushed a commit to ed-holland/abaplint-sci-client that referenced this issue Jul 10, 2020
* update description, abaplint#42

* handle namespaces
ed-holland pushed a commit to ed-holland/abaplint-sci-client that referenced this issue Jul 10, 2020
* update description, abaplint#42

* handle namespaces
ed-holland pushed a commit to ed-holland/abaplint-sci-client that referenced this issue Jul 11, 2020
* update description, abaplint#42

* handle namespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants