Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyLint Failures #9

Open
varshav0119 opened this issue Oct 5, 2021 · 6 comments
Open

Fix PyLint Failures #9

varshav0119 opened this issue Oct 5, 2021 · 6 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest Good Issue for Hacktoberfest 2021

Comments

@varshav0119
Copy link
Collaborator

varshav0119 commented Oct 5, 2021

Ignoring PyLint failures is probably not the best practice, but we haven't gotten around to fixing them yet 😂 .
The languages/english.py file especially has many issues to fix.

@varshav0119 varshav0119 added good first issue Good for newcomers hacktoberfest Good Issue for Hacktoberfest 2021 labels Oct 5, 2021
@LustigePerson
Copy link

LustigePerson commented Oct 5, 2021

If you could assign me to this issue, I'll have a look.

Actually it seems like you need a complete refactoring.
Without deeper knowledge on whow and where this is integrated I don't think one should start doing this.

  • Star imports
  • Unused Imports
  • Relative Imports (I would suggest to turn this into real modules)
  • Functions da do nothing
  • Variable naming

@anexas5
Copy link

anexas5 commented Oct 5, 2021

Please assign this issue to me.

@bauripalash
Copy link

@FruitVodka

I dont understand the necessity of pushing a temporary directory to the repository.

If the directory is used for something elese, you should rename it appropriately.

@Linta-Iqbal
Copy link

Please assign this issue to me.

Repository owner deleted a comment from ab-apps Oct 6, 2021
@varshav0119
Copy link
Collaborator Author

@FruitVodka

I dont understand the necessity of pushing a temporary directory to the repository.

If the directory is used for something elese, you should rename it appropriately.

Hmm the file within it is a temporary file to write down the results, which are picked up and read here to be sent as response to this API call.
Since there's an "exec" of a python program string happening here, couldn't think of a better way to do this.
Did you mean the results file shouldn't be in a directory named temp_dir, or that we shouldn't have a temporary results file in the first place?

@varshav0119
Copy link
Collaborator Author

If you could assign me to this issue, I'll have a look.

Actually it seems like you need a complete refactoring. Without deeper knowledge on whow and where this is integrated I don't think one should start doing this.

  • Star imports
  • Unused Imports
  • Relative Imports (I would suggest to turn this into real modules)
  • Functions da do nothing
  • Variable naming

@LustigePerson This is integrated with the web app. If you have any questions regarding what certain functions do, or issue with any variable naming, do get back and I'll be happy to clarify!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Good Issue for Hacktoberfest 2021
Projects
None yet
Development

No branches or pull requests

5 participants