Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a connection from Read+Write #162

Open
kpcyrd opened this issue Oct 27, 2018 · 1 comment
Open

Creating a connection from Read+Write #162

kpcyrd opened this issue Oct 27, 2018 · 1 comment

Comments

@kpcyrd
Copy link
Contributor

kpcyrd commented Oct 27, 2018

hello!

I'm wondering if it would be possible to extend the client to accept a generic object that implements Read+Write. Specifically I'm interested in creating the connection myself and handing it over to the irc crate.

That would also allow setting the tokio-tls and native-tls dependencies to optional to avoid linking to openssl.

@aatxe
Copy link
Owner

aatxe commented Nov 1, 2018

Hi!

Thanks for the suggestion. In principle, this should be possible, but I suspect that it would be a rather substantial (probably breaking) change. If you'd like to investigate it yourself, I'd be happy to offer support, feedback, and so forth along the way. If it can be done in a way that doesn't make the common case (i.e. using the library-provided connections) worse, I'd be happy to include it as part of the irc crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants