Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG REPORT] Lightsheet direction has no effect on deconvolution #25

Open
lacan opened this issue Sep 12, 2024 · 2 comments
Open

[BUG REPORT] Lightsheet direction has no effect on deconvolution #25

lacan opened this issue Sep 12, 2024 · 2 comments

Comments

@lacan
Copy link
Collaborator

lacan commented Sep 12, 2024

When defining the parameters with @romainGuiet for a theoretical LISH PSF, we can decide on the lightheet illumination direction, for example here as From bottom

image

But whatever value we set, it gets recorded as 0.000 in the parameters template that is sent to HuCore.
image

Moreover the parameter "from left|right|top|bottom" gets reset to from right each time we try to edit a previous template, meaning that it does not get recorded in HRM either...

@KevinNamink
Copy link
Collaborator

Thanks for the report.

This SPIM Direction is represented in various ways throughout the HRM and I suspect the translation utility could have broken without us noticing recently (as it has a few fallbacks that make it never return errors).
I currently don't have a debugging setup for the HRM running, I hope to have time to set this up and investigate more within a week.

A link to the function using the utility I suspect (probably linked here only for my own convenience):

public function translatedValue()
{
$db = DatabaseConnection::get();
$result = $db->translationFor($this->name, $this->value);
return $result;
}

If anything this file probably is related to the issue.

@KevinNamink
Copy link
Collaborator

I found out the translation from the mysql database to the GUI and to the Huygens template both went wrong. I think I fixed it in the latest commit in the devel branch (1309394).
I have no clue how this ever would have worked correctly.

Can you work with this fix in the devel branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants