Use unique_ptr for Grid in Cell #782
Merged
+39
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiolo
force-pushed
the
unique_ptr-cell-grid
branch
from
1b2bb8e to
1f27d12
Compare
tobiolo
force-pushed
the
unique_ptr-cell-grid
branch
2 times, most recently
from
29a2f0b to
28741c8
Compare
aardappel
reviewed
Dec 10, 2024
src/grid.h
Outdated
| @@ -1045,7 +1043,10 @@ struct Grid { | |||
| } | |||
| } | |||
| if (rest) { | |||
| swap_(c->grid, rest->grid); | |||
| Grid *cg = c->grid.release(); | |||
There was a problem hiding this comment.
Make it clear that Cell owns Grid `grid`.
tobiolo
force-pushed
the
unique_ptr-cell-grid
branch
from
28741c8 to
7a9f3da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.