Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display amount of cells selected in status bar #777

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

tobiolo
Copy link
Collaborator

@tobiolo tobiolo commented Dec 8, 2024

No description provided.

@tobiolo tobiolo force-pushed the amount-in-statusbar branch from 1fd9711 to ea9b8e6 Compare December 8, 2024 20:12
@tobiolo tobiolo requested a review from aardappel December 8, 2024 20:29
src/system.h Outdated
@@ -441,6 +441,12 @@ struct System {
}
}

void UpdateAmountStatus(Selection &s) {
if (frame->GetStatusBar()) {
frame->SetStatusText(wxString::Format(_(L"Amount %d"), s.xs * s.ys), 4);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe %d cells is more informative?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right! I updated the PR according to your proposal.

@tobiolo tobiolo force-pushed the amount-in-statusbar branch from ea9b8e6 to 59ccbc8 Compare December 9, 2024 06:33
@tobiolo tobiolo requested a review from aardappel December 9, 2024 06:36
@aardappel aardappel merged commit bbff91e into aardappel:master Dec 9, 2024
4 checks passed
@tobiolo
Copy link
Collaborator Author

tobiolo commented Dec 9, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants