Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate code (Home/End navigation) #513

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

tobiolo
Copy link
Collaborator

@tobiolo tobiolo commented Sep 19, 2023

No description provided.

@tobiolo tobiolo changed the title De-duplicate code De-duplicate code (Home/End navigation) Sep 19, 2023
This re-structures the logic a litte bit in order to avoid redundant lines.
@tobiolo
Copy link
Collaborator Author

tobiolo commented Sep 19, 2023

@aardappel
Do you think the extra abstraction is justified in this case? Thanks in advance for looking into this.

@aardappel
Copy link
Owner

Yes, I guess this one is fine :)

@aardappel aardappel merged commit fdef8a6 into aardappel:master Sep 20, 2023
4 checks passed
@tobiolo
Copy link
Collaborator Author

tobiolo commented Sep 20, 2023

Yes, I guess this one is fine :)

Thanks for having looked into this! Have a nice evening :-)
Best regards
Tobias

@tobiolo tobiolo deleted the deduplicate-code branch September 20, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants