From 45f63f7e1482ba2c89c6bc99d893299988181821 Mon Sep 17 00:00:00 2001 From: j-mendez Date: Mon, 18 Sep 2023 13:53:09 -0400 Subject: [PATCH] ci(install): fix browser install --- .github/workflows/bench.yml | 2 +- .github/workflows/perf.yml | 2 +- .github/workflows/tests.yml | 2 +- README.md | 4 +--- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/bench.yml b/.github/workflows/bench.yml index 6b124c07..d9bb793f 100644 --- a/.github/workflows/bench.yml +++ b/.github/workflows/bench.yml @@ -38,7 +38,7 @@ jobs: run: cd kayle_innate && wasm-pack build --target nodejs && cd ../ - name: Install and build locales - run: npx playwright install --with-deps chromium && yarn --no-immutable && yarn build + run: yarn --no-immutable && yarn build && npx playwright install --with-deps chromium - name: Run Bench playwright fast_axecore run: cd ./kayle && yarn bench:playwright:axe diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml index e542cee5..59db3484 100644 --- a/.github/workflows/perf.yml +++ b/.github/workflows/perf.yml @@ -38,7 +38,7 @@ jobs: run: cd kayle_innate && wasm-pack build --target nodejs && cd ../ - name: Install and build locales - run: npx playwright install --with-deps chromium && yarn --no-immutable && yarn build + run: yarn --no-immutable && yarn build && npx playwright install --with-deps chromium - name: Run Bench fast_htmlcs run: cd ./kayle && yarn bench:playwright:htmlcs > output.json diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index ae877c15..078960f5 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -38,7 +38,7 @@ jobs: run: cd kayle_innate && wasm-pack build --target nodejs && cd ../ - name: Install and build locales - run: npx playwright install --with-deps chromium && yarn --no-immutable && yarn build + run: yarn --no-immutable && yarn build && npx playwright install --with-deps chromium - name: Run Playwright kayle.js run: cd ./kayle && yarn test:playwright && yarn test:playwright:axe diff --git a/README.md b/README.md index d587a545..674c91bb 100644 --- a/README.md +++ b/README.md @@ -73,7 +73,7 @@ const results = await kayle({ }); ``` -![Video of clips being stored of the issue to get visual feedback](https://user-images.githubusercontent.com/8095978/268726837-f362a490-b611-4acf-8cb6-104f58a0a6c7.gif) +![Images of issues being stored of the to get visual feedback.](https://user-images.githubusercontent.com/8095978/268726837-f362a490-b611-4acf-8cb6-104f58a0a6c7.gif) ## Runners @@ -161,8 +161,6 @@ type RunnerConfig = { 1. zh-CN ("Chinese-Simplified") 1. zh-TW ("Chinese-Traditional") -![Video of clips being stored of the issue to get visual feedback](https://user-images.githubusercontent.com/8095978/268726837-f362a490-b611-4acf-8cb6-104f58a0a6c7.gif) - ## Testing For the comparison between using `fast_htmlcs`, `fast_axecore`, and the metrics for the 3rd party `@axe-core/playwright`.