Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build <Tooltip /> using PopperJS 🏗 #245

Open
0ubbe opened this issue Feb 27, 2020 · 0 comments
Open

Build <Tooltip /> using PopperJS 🏗 #245

0ubbe opened this issue Feb 27, 2020 · 0 comments
Labels
enhancement For discussing possible improvements

Comments

@0ubbe
Copy link
Contributor

0ubbe commented Feb 27, 2020

Summary

Currently our <Tooltip /> component is just a tiny wrapper around @tippy.js/react with styles and animation set.

@thegrinder pointed out fairly that we could build ourselves the styles using Popperjs ( which is what TippyJS uses internally ) and hence remove a dependency layer.

We would need to be careful to preserve the current behaviour and styling ( see related PRs )

Related

#164
#165
@0ubbe 0ubbe added the enhancement For discussing possible improvements label Feb 27, 2020
@0ubbe 0ubbe mentioned this issue Feb 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement For discussing possible improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0ubbe