ZCS-11064: add migration script for zimbra.zmg_devices table #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Nov 16, 2021
dasiyogesh
reviewed
Nov 17, 2021
| # | ||
| # ***** BEGIN LICENSE BLOCK ***** | ||
| # Zimbra Collaboration Suite Server | ||
| # Copyright (C) 2015, 2016 Synacor, Inc. |
There was a problem hiding this comment.
change the year to 2021
itsmeprashant
force-pushed
the
ZCS-11064
branch
from
d9e9342 to
d1d3a13
Compare
dasiyogesh
reviewed
Nov 17, 2021
| # | ||
| # ***** BEGIN LICENSE BLOCK ***** | ||
| # Zimbra Collaboration Suite Server | ||
| # Copyright (C) 2015, 2016, 2021 Synacor, Inc. |
There was a problem hiding this comment.
we don't need 2015, 2016 as this is new file and added in 2021. If this was existing file and was being updated then earlier years are fine.
dasiyogesh
reviewed
Nov 17, 2021
| @@ -0,0 +1,36 @@ | |||
| #!/usr/bin/perl | |||
There was a problem hiding this comment.
I think we should name the script file as migrate20211116-MobileNotificationDevices.pl. so that its clear whats this script is about or for which feature
itsmeprashant
force-pushed
the
ZCS-11064
branch
from
d1d3a13 to
c0b6d80
Compare
itsmeprashant
force-pushed
the
ZCS-11064
branch
2 times, most recently
from
d39e679 to
83f3b90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update zimbra.zmg_devices table.
Zimbra/zm-build#198
Zimbra/zm-mailbox#1207