Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZQ2 Converter : GetTxBlock has field differences #2133

Open
chetan-zilliqa opened this issue Jan 13, 2025 · 1 comment
Open

ZQ2 Converter : GetTxBlock has field differences #2133

chetan-zilliqa opened this issue Jan 13, 2025 · 1 comment
Labels
Agate Required for mainnet launch

Comments

@chetan-zilliqa
Copy link
Contributor

chetan-zilliqa commented Jan 13, 2025

Following are the observations.

  1. Fields such as HeaderSign and TxnFees are incorrect.
  2. Fields such as MbInfoHash and NumMicroBlocks are different. But we understand that we haven't converted microblocks , so these fields are not present.
  3. MinerPubKey is present in ZQ1 but missing in ZQ2.

ZQ1 curl:

curl --request POST \
  --url 'http://34.126.135.118:4201/?=' \
  --header 'Content-Type: application/json' \
  --data '{
    "id": "1",
    "jsonrpc": "2.0",
			"method": "GetTxBlock",
    "params": ["3277414"]
}'

ZQ2 curl:

curl --request POST \
  --url 'http://34.87.132.124:4202/?=' \
  --header 'Content-Type: application/json' \
  --data '{
    "id": "1",
    "jsonrpc": "2.0",
			"method": "GetTxBlock",
    "params": ["3277414"]
}'

Difference:


--- Viewing difference for GetTxBlock (3277415) ---

Keys present in ZQ1 but missing in ZQ2:
  root['result']['header']['MinerPubKey']

>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>



Values that differ between ZQ2 and ZQ1:
  root['result']['body']['HeaderSign']:
    ZQ2 -> 00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
    ZQ1 -> F7B8C93DF137EFD7768CEF1F82EFE159650EBF8BCE1D88A823B9189DE6B5B1F4FCC611C3A86D0C498E49FFB931F10B31010F66E5C2E78818A0C8FC8E99E8FF0D
  root['result']['header']['MbInfoHash']:
    ZQ2 -> 0000000000000000000000000000000000000000000000000000000000000000
    ZQ1 -> 69c419833e4a2965c5676212f7de5fbe87444c399bbac72239f5a9e4e5900e6f
  root['result']['header']['NumMicroBlocks']:
    ZQ2 -> 0
    ZQ1 -> 4
  root['result']['header']['StateDeltaHash']:
    ZQ2 -> 0000000000000000000000000000000000000000000000000000000000000000
    ZQ1 -> 7b0435f91c901bfc66a40e96a6be2c42e3fc9f863f6dfe09f7519fbc2fbdeb5f
  root['result']['header']['StateRootHash']:
    ZQ2 -> 1742af57170881877514c7c133d14b9cf4ff98b7b8ebdd7f9881d26d0a89e2e5
    ZQ1 -> 1b1fb5012b34bb197e4fb90de4d3fdd80af4ec8be77282407d67f648629c885e
  root['result']['header']['TxnFees']:
    ZQ2 -> 4002852142856502480
    ZQ1 -> 5197899841600

>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>



Lists empty in ZQ2 but populated in ZQ1:
  root['result']['body']['MicroBlockInfos']:
    ZQ2 -> []
    ZQ1 -> [{'MicroBlockHash': 'f6b5fdd09f5702b9e4dfe4996878369770840af56ffda318eca65f3dfa7a8c7d', 'MicroBlockShardId': 0, 'MicroBlockTxnRootHash': '554e24ce229d97ae2a6eecd586f36166e324d55b274c33326223fe89c00ddc59'}, {'MicroBlockHash': '4e8392cbffbb873ed80c824a156ee23e2d2c8812c450b57e39e886e99bee0931', 'MicroBlockShardId': 1, 'MicroBlockTxnRootHash': '18858a7b101621f0aeb50d11652a20ada2a10b3a2d69f6690ab4f09cda718937'}, {'MicroBlockHash': 'bf7761b200865b15862979f4d7d3ae695b8596bca6a95cdf2acc133eeb7daa35', 'MicroBlockShardId': 2, 'MicroBlockTxnRootHash': '29addc9b3329ea79ec6cb7dc9b9b8fe9c511b18a790d7d52de0bc6a5a63e9fef'}, {'MicroBlockHash': '18331e574c19178699572f13679dd93420e9895b0896dfdd47767887f61a9745', 'MicroBlockShardId': 3, 'MicroBlockTxnRootHash': '00e918e5817409cdfced311f727f3b78c0e657b5c116e7a91c1fbc3bfda51f98'}]

>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>






@chetan-zilliqa chetan-zilliqa added the Agate Required for mainnet launch label Jan 13, 2025
@maxconway
Copy link
Contributor

@chetan-zilliqa MbInfoHash, NumMicroBlocks and header_sign are already labelled as obsolete in ZQ2. MinerPubKey we've already discussed but is probably a conversion issue rather than an API issue, so I'm not necessarily the right person to work on it because I haven't touched the converter or get ZQ1 experience. Would it be possible to break this down into the specific issues and I'll unassign myself for now?

@maxconway maxconway removed their assignment Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agate Required for mainnet launch
Projects
None yet
Development

No branches or pull requests

2 participants