Enable CongestionControl::Block if QoS is reliable. #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With DDS the only combination of QoS which makes a Publisher to block the publications in case of network congestion is with Reliability=RELIABLE and History=KEEP_ALL.
In order to closely mimic this behaviour
rmw_zenoh
is settingZ_CONGESTION_CONTROL_BLOCK
only for this combinaison of QoS.However, in case of a Publisher for a "latched topic", it will use such combination of QoS:
Reliability=RELIABLE, History=KEEP_LAST(1) and Durability=TRANSIENT_LOCAL.
This leads
rmw_zenoh
to setZ_CONGESTION_CONTROL_DROP
for the Publisher. And in case of very congested network the single publication might be dropped. That's what happens in the case discussed here:#38 (comment)
This PR solves this problem setting
Z_CONGESTION_CONTROL_BLOCK
for any Publisher with QoS Reliability=RELIABLE, whatever the other QoS are.