Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize data.cljs #103

Open
tbeddy opened this issue Oct 31, 2017 · 1 comment
Open

Reorganize data.cljs #103

tbeddy opened this issue Oct 31, 2017 · 1 comment

Comments

@tbeddy
Copy link
Contributor

tbeddy commented Oct 31, 2017

Even when using a more compact representation for maps (q, r, terrain-type on one line), adding all of the maps from Elite Command pushes data.cljs over 11k LoC, and it's only going to get longer. We should break it up into a few related files and break maps up further into map-packs.

@djwhitt
Copy link
Contributor

djwhitt commented Nov 26, 2017

I'm fine with splitting it up into different namespaces. In the long term, we should move most if not all of the data out of the code base and into separate data files (#40 is related).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants