Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip episode if another is mapped to its value #518

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

cameronkinsella
Copy link
Contributor

If a TVDB episode is mapped to a value that already exists in TVDB then duplicate episodes will be matched. This causes only the final match to be used for metadata, which could be the wrong one.

This fix should resolve the episode name mapping issue for anidb to TVDB.

Since thumbnails are still stored by their mapped values, this does not resolve the issue where the incorrect thumbnails are sometimes chosen as the default. In this case, the correct thumbnail will still be available as the second choice when editing the episode in plex, so you can manually fix them without too much effort.

Partially resolves #500

If a TVDB episode is mapped to a value that already exists in TVDB then
duplicate episodes will be matched. This causes only the final match
to be used for metadata, which could be the wrong one.
@cameronkinsella
Copy link
Contributor Author

I have only tested this with one affected series (Monogatari series), so I would appreciate it if someone else could test it as well.

@natyusha
Copy link
Contributor

Tested with several series that were previously mapped incorrectly and this fixed all of them.

@ZeroQI ZeroQI merged commit c24f2e3 into ZeroQI:master Jun 30, 2022
@cameronkinsella cameronkinsella deleted the bug/Fix_duplicate_mapping branch June 30, 2022 13:13
@zyfinity01
Copy link

Does this also fix the poster being incorrect such as in issue #500 ?

@plato79
Copy link

plato79 commented Jul 22, 2022

This didn't fix the problem in #500 (comment)

@natyusha
Copy link
Contributor

The pr does what it says and fixes the matching for series that share things under the same entry on tvdb (multiple seasons / specials / ovas / movies).

I saw "Violet Evergarden Gaiden: Eien to Jidou Shuki Ningyou" used as an example of a movie that isn't matching correctly but that is actually an issue with anime-list-master.xml which is pointing to the wrong episode.

<anime anidbid="14840" tvdbid="330139" defaulttvdbseason="0" episodeoffset="1" tmdbid="610892" imdbid="tt10477558">
  <name>Violet Evergarden Gaiden: Eien to Jidou Shuki Ningyou</name>
</anime>

It is pointing to season 0 of the main series (which doesn't contain any trace of the movie).

@plato79
Copy link

plato79 commented Jul 25, 2022

Well, so the problem in #500 is on the metadata and not in the code then if I understand correctly..

The weird thing is when I undo b475676 this appear correctly so it was pulling the data another way before this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple TVDB episodes mapped to the same anidb episode
5 participants