Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TheTVDB to AniDB reverse mapping maps two episode to the same season and episode, resulting in bad metadata #496

Closed
littleneko opened this issue Dec 25, 2021 · 5 comments

Comments

@littleneko
Copy link

The "Evangelion" movie "新世紀エヴァンゲリオン劇場版 Air / まごころを, 君に" (https://anidb.net/anime/202) and "新世紀エヴァンゲリオン劇場版 シト新生" (https://anidb.net/anime/326) display the episode as "Evangelion TV" (https://anidb.net/anime/326)

Same as the other anime movie and tv, like movie "冴えない彼女の育てかた Fine" (https://anidb.net/anime/13626) and TV "冴えない彼女の育てかた" (https://anidb.net/anime/10538).

The TV:
image

The Movie:
image
image

@ZeroQI
Copy link
Owner

ZeroQI commented Dec 25, 2021

No scanner logs
no agent search log
No agent update log
Which title and source is used is in the series specific update log at the end

@ZeroQI
Copy link
Owner

ZeroQI commented Dec 26, 2021

Technical analysis:

[Salender-Raws] Evangelion\Death & Rebirth[Salender-Raws] Evangelion - Death & Rebirth (DVD 924x524 x264 AC3 5.1).mkv in filelist.log
Mapped to s01e01 in scanner.log
Assigned to anidb-326 in search.log so anidb numbering is used

metadata.seasons[ 1].episodes[ 1]
[?] rank: 0, source_title: TheTVDB, title: "使徒、襲来"
[x] title Sources: TheTVDB, AniDB| (TheTVDB), AniDB Inside: '['TheTVDB']' Value: '使徒、襲来'

Showing in logs the title affectation for s01e01
Mapping show AniDB s01e01-02 maps to TVDB s00e01

 'TVDB': {'s0e0': ('0', '1', '326'), 's0e1': ('1', '1', '326'), 's-1': {'326': '0'}},
  'tvdbcount': 1}

TheTVDB detected the following episodes present:
[X] s0e1 s01e001 anidbid: 326 air_date: 1997-03-15 abs_number: 0, title: 新世紀エヴァンゲリオン劇場版 シト新生
[X] s1e1 s01e001 anidbid: xxxxxxx air_date: 1995-10-04 abs_number: 1, title: 使徒、襲来

  • [1] title: [ja] 使徒、襲来

Because of TheTVDB file détection, two episodes are detected and assigned to s01e01, so the first mapping is lost... A failsafe and algorithm correction needs to be coded indeed.

https://github.com/ZeroQI/Hama.bundle/blob/master/Contents/Code/TheTVDBv2.py line 186

@ZeroQI ZeroQI changed the title Wrong episode title for anime movie Bad TheTVDB file présent détection causing wrong episode title Dec 26, 2021
@ZeroQI ZeroQI changed the title Bad TheTVDB file présent détection causing wrong episode title TheTVDB to AniDB reverse mapping maps two episode to the same season and episode, resulting in bad metadata Feb 3, 2022
@ZeroQI
Copy link
Owner

ZeroQI commented Feb 7, 2022

The function that maps TheTVDB to AniDB ep number has flaws

@ZeroQI
Copy link
Owner

ZeroQI commented Mar 12, 2022

Your issue is that the mapping assign 2 tvdb eps to s01e-001, already mentioned on

Will keep 500 which has better description and pinpointed the change that broke it, and close other bug reports

@ZeroQI ZeroQI closed this as completed Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants