Minor changes and debugging #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Thanks, i'll review the code, and hope to see you back in the future |
… 0), and causing php notices
|
No doubt you are busy. |
…st be of type int|float, string given in zcDPU_Ajax.php:184 make stock int
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a sudden change of circumstances I cannot devote any further time to this, so have to present it now before it gathers dust.
My testing has been using declare(strict_types=1); in all files, but removed for this PR, so the code should be more robust.
Debugging is added and enabled using a define in the (non ajax) class to enable both jscript console output and a logfile. The logfile is cleared on each attribute change, but this can be modified in the ajax class.
Testing has been with the Bugs Life Collectors Edition, and as far as I can tell, all the attribute changes work, apart from selecting multiple checkboxes.