Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing metronome sound #5

Open
kakajuro opened this issue Aug 28, 2023 · 3 comments
Open

Changing metronome sound #5

kakajuro opened this issue Aug 28, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kakajuro
Copy link

Have you considered adding the ability to change between a couple of metronome tick sounds?
Super nice app btw

@ZaneH
Copy link
Owner

ZaneH commented Aug 28, 2023

Hi swishyy, thank you btw

Unfortunately changing the sound isn't easy, here is what the "boop" sound looks like. It's a synthesized sine wave played for a short instant. I just don't have the knowledge/motivation to add different boops to this! A PR would be welcome if you decided to.

edit: It's being synthesized like this for exact timing. Playing an mp3 for example isn't exact

@kakajuro
Copy link
Author

Thanks for the quick reply!

It makes sense mp3 files wouldn't be that precise which is something I didn't really think about. I feel like it might be possible to generate different tones for the click sound with Tonejs but it would take a fair amount of experimentation. I might mess around with it and when I get the chance but I can't guarantee a PR or anything since I haven't used the library before.

@ZaneH
Copy link
Owner

ZaneH commented Aug 29, 2023

It was a surprise to me too! First thing I tried was mp3s but it was terribly off-beat. I'll leave this issue open for about a month or two just in case. It'd be really cool if you can get some different sounds working, but don't feel obligated. If you do manage to get it, feel free to create a PR and I can assist in adding the settings menu, etc.

@ZaneH ZaneH added the enhancement New feature or request label Aug 29, 2023
@ZaneH ZaneH added the help wanted Extra attention is needed label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants