Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results reproducibility: maximum sequence length #5

Open
oshapio opened this issue Jan 31, 2019 · 0 comments
Open

Results reproducibility: maximum sequence length #5

oshapio opened this issue Jan 31, 2019 · 0 comments

Comments

@oshapio
Copy link

oshapio commented Jan 31, 2019

Hello,
I went through your paper and didn't see maximum length of the sequence for each dataset being mentioned. In "train.sh" I saw that the value used was 200, while in the train.py I saw that the default value was set to 10000. Could you clarify which value was used when reporting the results?

It's important, because in order to fairly compare methods I need to know how many test cases to generate, as they are proportional to the maximum sequence length.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant