forked from EvanOxfeld/node-unzip
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
offsetToLocalFileHeader greater than 32-bit int limit throws exceptions #324
Comments
emmercm
added a commit
to emmercm/igir
that referenced
this issue
Jun 22, 2024
emmercm
added a commit
to emmercm/igir
that referenced
this issue
Jun 22, 2024
Hi there, I was looking into it as I faced the same issue. Debugging my way through, I discovered that the problem lies with the extra field of Zip64. The current logic expects all fields to always be present in the Zip64 entry (which is not necessarily the case). I changed the logic to check which values should be present based on the values in the Zip64 central directory. |
emmercm
added a commit
to emmercm/igir
that referenced
this issue
Jul 17, 2024
emmercm
added a commit
to emmercm/igir
that referenced
this issue
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When parsing a large zip file with:
if a file's
offsetToLocalFileHeader
is greater than the 32-bit integer max value of 4,294,967,296, its value will end up beingnull
and not a number:which will throw an
ERR_INVALID_ARG_TYPE
exception when trying to get a stream to the file:System info:
Here's an example zip file, this problem happens with central directory entries 19-28:
The text was updated successfully, but these errors were encountered: