Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor DeviceInfo issues #131

Merged
merged 3 commits into from
May 24, 2024
Merged

Fix minor DeviceInfo issues #131

merged 3 commits into from
May 24, 2024

Conversation

AdamVe
Copy link
Member

@AdamVe AdamVe commented May 20, 2024 •
edited
Loading

Fixes following:

  • STM and FPS versions, parsed as 0.0.0 will be treated as null.
  • Fix to default value of nfcRestricted
  • Change of type of partNumber to be nullable

@AdamVe AdamVe changed the title Update device info parser Fix minor DeviceInfo issues May 24, 2024
jensutbult
jensutbult approved these changes May 24, 2024
View reviewed changes
Copy link

@jensutbult jensutbult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdamVe AdamVe merged commit 36459c9 into main May 24, 2024
5 checks passed
@AdamVe AdamVe deleted the adamve/fixVersionParsing branch May 24, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensutbult jensutbult jensutbult approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamVe @jensutbult