multiple potential memory leaks

[invd]

During recent dynamic program analysis of the code, I noticed that there are a number of cases where allocated memory is not correctly free()'ed. This happens mainly due to suboptimal memory handling in error cases.
The practical impact of the memory leaks is close to zero on normal usage since the command line programs exit after a brief run. As briefly discussed with @nevun, I'm not aware of any security impact.

1. ykpers-args.c key_tmp
   

   yubikey-personalization/ykpers-args.c

   Lines 789 to 799 in 6212797

   	char *key_tmp = NULL;
   	char keybuf[20];
   	if(keylocation == 2) {
   	const char *prompt = " AES key, 16 bytes (32 characters hex) : ";
   	if (key_bytes == 20) {
   	prompt = " HMAC key, 20 bytes (40 characters hex) : ";
   	}
   	if (prompt_for_data(prompt, &key_tmp) != 0) {
   	*exit_code = 1;
   	return 0;

calloc() via prompt_for_data(), problematic in the return 0; case.

2. ykpers-args.c uidtmp
   

   yubikey-personalization/ykpers-args.c

   Lines 554 to 559 in 6212797

   	char *uidtmp = NULL;
   	if(strncmp(optarg, "uid=", 4) != 0) {
   	if(prompt_for_data(" Private ID, 6 bytes (12 characters hex) : ", &uidtmp) != 0) {
   	*exit_code = 1;
   	return 0;

calloc() via prompt_for_data(), problematic in the return 0; case.

3. ykpersonalize.c
   

   yubikey-personalization/ykpersonalize.c

   Line 244 in 6212797

   exit(1);

   
   I think this should likely go through the error handling (although the exit(1) will properly unclaim the memory as well):

			exit_code = 1;
			goto err;