From 26fd65e6d64b7b206eb4515fb3adbddaefe8aeee Mon Sep 17 00:00:00 2001
From: Elias Bonnici <elias.bonnici@yubico.com>
Date: Mon, 7 Aug 2023 16:21:57 +0200
Subject: [PATCH] HSMAUTH: change credential password format in tests

---
 tests/device/test_hsmauth.py | 10 +++++-----
 tests/test_hsmauth.py        |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/device/test_hsmauth.py b/tests/device/test_hsmauth.py
index 9bb7bedb..84d396f1 100644
--- a/tests/device/test_hsmauth.py
+++ b/tests/device/test_hsmauth.py
@@ -33,7 +33,7 @@ def session(ccid_connection):
 def import_key_derived(
     session,
     management_key,
-    credential_password=b"123456",
+    credential_password="123456",
     derivation_password=b"password",
 ) -> Credential:
     credential = session.put_credential_derived(
@@ -47,7 +47,7 @@ def import_key_derived(
 
 
 def import_key_symmetric(
-    session, management_key, key_enc, key_mac, credential_password=b"123456"
+    session, management_key, key_enc, key_mac, credential_password="123456"
 ) -> Credential:
     credential = session.put_credential_symmetric(
         management_key,
@@ -61,7 +61,7 @@ def import_key_symmetric(
 
 
 def import_key_asymmetric(
-    session, management_key, private_key, credential_password=b"12345"
+    session, management_key, private_key, credential_password="123456"
 ) -> Credential:
     credential = session.put_credential_asymmetric(
         management_key,
@@ -74,7 +74,7 @@ def import_key_asymmetric(
 
 
 def generate_key_asymmetric(
-    session, management_key, credential_password=b"12345"
+    session, management_key, credential_password="123456"
 ) -> Credential:
     credential = session.generate_credential_asymmetric(
         management_key,
@@ -206,7 +206,7 @@ def test_management_key_retries(self, session):
 
 class TestSessionKeys:
     def test_calculate_session_keys_symmetric(self, session):
-        credential_password = b"1234"
+        credential_password = "1234"
         credential = import_key_derived(
             session,
             DEFAULT_MANAGEMENT_KEY,
diff --git a/tests/test_hsmauth.py b/tests/test_hsmauth.py
index 62e91687..68a7c002 100644
--- a/tests/test_hsmauth.py
+++ b/tests/test_hsmauth.py
@@ -22,7 +22,7 @@ def test_generate_random_management_key(self):
         assert 16 == len(output1) == len(output2)
 
     def test_parse_credential_password(self):
-        parsed_credential_password = _parse_credential_password(b"123456")
+        parsed_credential_password = _parse_credential_password("123456")
 
         assert (
             b"123456\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00"