-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli can find Yubikey but not GUI #361
Comments
This is due to the usage of Python 3.12 which is not supported by pyotherside (yet, see thp/pyotherside#131 etc). As a workaround you can download https://raw.githubusercontent.com/Yubico/yubikey-manager-qt/main/ykman-gui/py/yubikey.py to |
Thank you this also worked for me! |
Thanks, it worked for me ! |
This doesn't fix the issue for me. |
I have bisected the offending commit |
This might be fixed with #363 |
the patch in #363 has so many unrelated changes. not sure how this happened. the minimal patch is:
|
My changes in #363 are not unrelated, your minimal patch just fixes the python code while still leaving a broken UI if you click in the wrong buttons etc. my patch also removes the functionality from the UI
…On Mon, Aug 5, 2024, at 23:50, darix wrote:
the patch in #363
<#363> has so many
unrelated changes. not sure how this happened. the minimal patch is:
`diff --git a/ykman-gui/py/yubikey.py b/ykman-gui/py/yubikey.py
index 2c91bc4..32a2b37 100644
--- a/ykman-gui/py/yubikey.py
+++ b/ykman-gui/py/yubikey.py
@@ -50,12 +50,10 @@ from ykman import __version__ as ykman_v
if int(ykman_v.split(".")[0] ) > 4:
from yubikit.support import get_name
from ykman.device import list_all_devices, scan_devices
- from ykman.otp import (
- _PrepareUploadFailed as PrepareUploadFailed
- , _prepare_upload_key as prepare_upload_key, generate_static_pw)
+ from ykman.otp import (generate_static_pw)
else:
from ykman import connect_to_device, scan_devices, get_name
- from ykman.otp import PrepareUploadFailed, prepare_upload_key,
generate_static_pw
+ from ykman.otp import generate_static_pw
from fido2.ctap2 import Ctap2, ClientPin
@@ -400,17 +398,6 @@ class Controller(object):
upload_url = None
with self._open_device([OtpConnection]) as conn:
- if upload:
- try:
- upload_url = prepare_upload_key(
- key, public_id, private_id,
- serial=self._dev_info['serial'],
- user_agent='ykman-qt/' + app_version)
- except PrepareUploadFailed as e:
- logger.debug('YubiCloud upload failed', exc_info=e)
- return failure('upload_failed',
- {'upload_errors': [err.name
- for err in e.errors]})
try:
session = YubiOtpSession(conn)
session.put_configuration(
`
—
Reply to this email directly, view it on GitHub
<#361 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAT5CYCW2B7WJWPU64S273ZP7XRLAVCNFSM6AAAAABG6KD5Q6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRZHE3TSOJSGQ>.
You are receiving this because you commented.Message ID:
***@***.***>
|
the changes in .github/workflow/ seem unrelated still. |
It is not really unrelated. It removes a patch for macosx that was needed for the otp upload functionality which your and my patch removes.
…On Tue, Aug 6, 2024, at 10:11, darix wrote:
the changes in .github/workflow/ seem unrelated still.
—
Reply to this email directly, view it on GitHub
<#361 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAT5CYHXZYRGDYIYACZ6VLZQCAKLAVCNFSM6AAAAABG6KD5Q6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZQGY2TGMRZHA>.
You are receiving this because you commented.Message ID:
***@***.***>
|
FWIW yubikey-manager-qt is apparently deprecated since three months: 28dc02d As such I have switched to the Yubico Authenticator which works well enough. So instead of trying to patch this in distros, they should probably get rid of this package and switch over to the authenticator. |
yeah. I already asked them to maybe archive the now deprecated projects via Yubico/yubikey-manager#627 |
rpm-ostree install yubikey-manager-qt
cli can find Yubikey but not GUI
Steps to reproduce
Expected result
Yubikey show up in the GUI
Actual results
Nothing Showed up
Other info
The text was updated successfully, but these errors were encountered: