[examples/cred] Support self attestation #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! One minor nitpick, could you please amend your commit message so that the subject/title line does not end in a period? (Ideally, we'd also like the subject line a little shorter, but this is not as critical.) Thank you! |
James-ZHANG
changed the title
James-ZHANG
changed the title
James-ZHANG
force-pushed
the
example-cred-support-self-attestation
branch
from
e197857 to
82afb8c
Compare
Done. |
LDVG
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some attestation format, e.g.
packed, allows self attestation [1]. And when that happens,fido_cred_x5c_ptrwould beNULL, makingfido_cred_verifyfail.[1] https://w3c.github.io/webauthn/#sctn-packed-attestation