Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch Between python_requires and requirements.txt Constraints #122

Open
gboeer opened this issue Dec 10, 2024 · 2 comments
Open

Mismatch Between python_requires and requirements.txt Constraints #122

gboeer opened this issue Dec 10, 2024 · 2 comments

Comments

@gboeer
Copy link

gboeer commented Dec 10, 2024

Hi,

I believe there’s a potential mismatch between the python_requires specification in setup.py and the fixed package version specified in requirements.txt.

Here are the details:

In setup.py, the package specifies:

setuptools.setup(
    python_requires=">=3.6"
)

In requirements.txt, the following is specified:

# verified versions
onnxruntime==1.8.0

However, when using Python 3.10.15 (in my case):

python --version
Python 3.10.15

The lowest installable version of onnxruntime via pip install is 1.12.0, not 1.8.0.

This suggests that onnxruntime==1.8.0 is incompatible with Python 3.10. As a result, it becomes difficult to use this package as is on Python versions greater than 3.9, even though the python_requires specification claims support for Python versions >= 3.6.

Expected Behavior:

The python_requires and requirements.txt should align so that the package can be installed with Python versions that are officially supported.

Suggested Fix:

Update requirements.txt to include a compatible version range for onnxruntime that works with Python 3.10.

Alternatively, adjust python_requires in setup.py to reflect the actual supported Python versions based on dependency compatibility.

Additional Context:
This mismatch can create confusion for users who are trying to use the package on newer Python versions. Please let me know if I’m misunderstanding anything or if there are other considerations.

@Elstuhn
Copy link

Elstuhn commented Dec 12, 2024

Hey Gordon, if you are having troubles on installation, the below is the readme for installation quick start, it worked for me let me know if you have any problems!

git clone [email protected]:YuHengsss/YOLOV.git
cd YOLOV
conda create -n yolov python=3.7

conda activate yolov

pip install -r requirements.txt

pip3 install -v -e .

@gboeer
Copy link
Author

gboeer commented Dec 12, 2024

Thanks for your answer, I got it to install with python version 3.10., I wouldn't want to use an ancient version like 3.7, I mean even 3.8. is deprecated now in most packages.

Had to ship around some problems with YOLOX first though:
Megvii-BaseDetection/YOLOX#1814

I still think the issue is valid, since the main problem stated here is, that the setup files for this YOLOV are not valid, i.e. some of the fixed requirements are not available for newer python versions, but the setup.py states that anything above python 3.6. will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants