tests: replace read_ilang with read_rtlil #4762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* YosysHQ#4612 was written before read_ilang was deprecated but merged after so caused test failures. This switches read_ilang to read_rtlil
|
Merging a PR with green CI and getting red on main reminds me once again of this post on rustc's bors |
|
Isn't that also what merge queues are for? |
|
I would also point out that read_ilang has been deprecated for circa 5 years, it's only just now been removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4612 was written before read_ilang was deprecated but merged after so caused test failures. This switches read_ilang to read_rtlil in its testcase.