Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R-squared #91

Open
drisso opened this issue Nov 22, 2017 · 1 comment
Open

R-squared #91

drisso opened this issue Nov 22, 2017 · 1 comment

Comments

@drisso
Copy link
Contributor

drisso commented Nov 22, 2017

This line of code:

scone/R/scone_eval.R

Line 319 in e2436a3

lm(y ~ qc_factors)$residual

could be more easily written as:

summary(lm(y ~ qc_factors))$r.squared
@drisso
Copy link
Contributor Author

drisso commented Nov 22, 2017

But it could be less efficient since summary computes a bunch of things not just the R-squared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drisso