Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scran "sizes" parameter #86

Open
drisso opened this issue Jun 14, 2017 · 4 comments
Open

scran "sizes" parameter #86

drisso opened this issue Jun 14, 2017 · 4 comments

Comments

@drisso
Copy link
Contributor

drisso commented Jun 14, 2017

Currently, the scran wrapper in SCONE uses a value of sizes that is not the default in scran:
https://github.com/YosefLab/scone/blob/master/R/SCONE_DEFAULTS.R#L136

@mbcole what is the rationale for this value? Why not using the scran default seq(20, 100, 5)?

@drisso
Copy link
Contributor Author

drisso commented Jul 12, 2017

scran_fn <- function(ei) {
  sce <- newSCESet(countData=data.frame(ei))
  sce <- computeSumFactors(sce, sizes = seq(20, NCOL(ei), 5))
  sce <- normalize(sce)
  eo <- norm_exprs(sce)
  return(2^eo - 1)
}

scran_cluster_fn <- function(ei) {
  sce <- newSCESet(countData=data.frame(ei))
  cl <- quickCluster(sce, min.size = 50)
  sce <- computeSumFactors(sce, clusters = cl, sizes = min(table(cl)))
  sce <- normalize(sce)
  eo <- norm_exprs(sce)
  return(2^eo - 1)
}

@mbcole
Copy link
Contributor

mbcole commented Aug 17, 2017

@drisso what's the motivation behind seq(20, NCOL(ei), 5) in scran_fn?

Why not use the default you cited above?

@drisso
Copy link
Contributor Author

drisso commented Aug 27, 2017

I was using the default, which is sizes=seq(20, 100, 5), but I've changed it for the fluidigm data that has only ~70 cells. I guess a better way would be sizes=seq(20, min(100, NCOL(ei)), 5)...

@ghost
Copy link

ghost commented Mar 24, 2020

I am trying to learn how to use scran with scone. What is newSCESet here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants