From 4c389e78890bf10b2ea1dc52b1aee73e25491233 Mon Sep 17 00:00:00 2001 From: Staffan Olsson Date: Tue, 8 Oct 2019 21:12:07 +0200 Subject: [PATCH] There's no reason to ever recommend auto.create.topics=true I though that the feature would be neat for development (with replication factor 1, see #222) but it causes just as much confusion and useless troubleshooting there, for example race conditions between intentional topic creation and a container starting up to produce to the topic. You actually never know which topic config you're getting. Related: #107 The duplication is a workaround for https://github.com/kubernetes-sigs/kustomize/issues/642 --- variants/dev-small/auto-create-topics.json | 2 -- variants/dev-small/listener-localhost.json | 2 -- 2 files changed, 4 deletions(-) diff --git a/variants/dev-small/auto-create-topics.json b/variants/dev-small/auto-create-topics.json index e607f0d8..269b95e9 100644 --- a/variants/dev-small/auto-create-topics.json +++ b/variants/dev-small/auto-create-topics.json @@ -2,7 +2,5 @@ {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"}, {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "advertised.listeners=PLAINTEXT://:9092,OUTSIDE://localhost:9094"}, {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"}, - {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "auto.create.topics.enable=true"}, - {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"}, {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "num.partitions=1"} ] diff --git a/variants/dev-small/listener-localhost.json b/variants/dev-small/listener-localhost.json index e607f0d8..269b95e9 100644 --- a/variants/dev-small/listener-localhost.json +++ b/variants/dev-small/listener-localhost.json @@ -2,7 +2,5 @@ {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"}, {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "advertised.listeners=PLAINTEXT://:9092,OUTSIDE://localhost:9094"}, {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"}, - {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "auto.create.topics.enable=true"}, - {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "--override"}, {"op": "add", "path": "/spec/template/spec/containers/0/command/-", "value": "num.partitions=1"} ]