From e0f544b22ba98c03a22a26a3285da8618b296ddc Mon Sep 17 00:00:00 2001 From: IreneStr Date: Tue, 7 May 2019 08:14:30 +0200 Subject: [PATCH 1/3] Revert "CS: fix capitalization in class names" This reverts commit 87aef6aa623a5076293064ebcd85de720d6e5fe5. Because capitalization matters when loading dependencies with composer like we do in our plugins, this is in a way a breaking change. That's why I'm reverting it for now. --- README.md | 8 ++++---- src/i18n-v3.php | 2 +- src/i18n-wordpressorg-v3.php | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index f612adf..b62fa25 100644 --- a/README.md +++ b/README.md @@ -22,7 +22,7 @@ Alternatively you can include the library as a submodule. Make sure the class is loaded and instantiate it like this: ```php -new Yoast_I18n_V3( +new Yoast_I18n_v3( array( 'textdomain' => '{your text domain}', 'project_slug' => '{your probject slug}', @@ -39,7 +39,7 @@ new Yoast_I18n_V3( Because translate.wordpress.org is also a GlotPress installation you can use the i18n-module to promote translation your plugin on there. To do this you can use the dedicated wordpress.org class: ```php -new Yoast_I18n_WordPressOrg_V3( +new Yoast_I18n_WordPressOrg_v3( array( 'textdomain' => '{your text domain}', 'plugin_name' => '{your plugin name}', @@ -53,7 +53,7 @@ new Yoast_I18n_WordPressOrg_V3( Since 3.0.0 you can also decide to render the message in a message-box of your own, just provide the second argument to the constructor as `false` to disable the showing of the box by the module itself. ```php -$i18n_module = new Yoast_I18n_V3( +$i18n_module = new Yoast_I18n_v3( array( 'textdomain' => '{your text domain}', 'project_slug' => '{your probject slug}', @@ -71,7 +71,7 @@ $message = $i18n_module->get_promo_message(); ``` ```php -$i18n_module = new Yoast_I18n_WordPressOrg_V3( +$i18n_module = new Yoast_I18n_WordPressOrg_v3( array( 'textdomain' => '{your text domain}', 'plugin_name' => '{your plugin name}', diff --git a/src/i18n-v3.php b/src/i18n-v3.php index b885efc..973bb4a 100644 --- a/src/i18n-v3.php +++ b/src/i18n-v3.php @@ -9,7 +9,7 @@ * This class defines a promo box and checks your translation site's API for stats about it, * then shows them to the user. */ -class Yoast_I18n_V3 { +class Yoast_I18n_v3 { /** * Your translation site's logo. diff --git a/src/i18n-wordpressorg-v3.php b/src/i18n-wordpressorg-v3.php index d24a39a..63e2b92 100644 --- a/src/i18n-wordpressorg-v3.php +++ b/src/i18n-wordpressorg-v3.php @@ -8,12 +8,12 @@ /** * The Yoast i18n module with a connection to WordPress.org. */ -class Yoast_I18n_WordPressOrg_V3 { +class Yoast_I18n_WordPressOrg_v3 { /** * The i18n object that presents the user with the notification. * - * @var yoast_i18n_V3 + * @var yoast_i18n_v3 */ protected $i18n; @@ -28,7 +28,7 @@ class Yoast_I18n_WordPressOrg_V3 { public function __construct( $args, $show_translation_box = true ) { $args = $this->set_defaults( $args ); - $this->i18n = new Yoast_I18n_V3( $args, $show_translation_box ); + $this->i18n = new Yoast_I18n_v3( $args, $show_translation_box ); $this->set_api_url( $args['textdomain'] ); } From bd2ca7d2b2abaa5516ef669052d5223385219eb2 Mon Sep 17 00:00:00 2001 From: IreneStr Date: Tue, 7 May 2019 08:31:40 +0200 Subject: [PATCH 2/3] Exclude PEAR.NamingConventions.ValidClassName.Invalid globally --- .phpcs.xml.dist | 1 + 1 file changed, 1 insertion(+) diff --git a/.phpcs.xml.dist b/.phpcs.xml.dist index 57695dc..1334ced 100644 --- a/.phpcs.xml.dist +++ b/.phpcs.xml.dist @@ -38,6 +38,7 @@ + From 86400f30e8388d2cbf3d5a0cb3a8896272d75134 Mon Sep 17 00:00:00 2001 From: IreneStr Date: Tue, 7 May 2019 08:32:05 +0200 Subject: [PATCH 3/3] Add 3.1.1 changelog --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index f6bbd52..261e47c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). +## 3.1.1 + +### Fixed +- Reverts the capitalization of the class names. + ## 3.1.0 ### Fixed