You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
I haven't been very consistent so far but most have followed the puppeteer API, but with snake casing and using kwargs insteads of options dicts. We should clean this up and decide whether to
mimic the puppeteer interface exactly,
make a "pythonic" version of the puppeteer interface, or
I think i'd agree with steve to make it pythonic. since this is supposed to be a python interface to puppeteer it probably shouldnt matter to puppy's api what puppeteer was written with or it's conventions
I would agree with the pythonic version, I think trying to mimic puppeteer interface (pypeteer) was confusing in development and in usage for our current ypuppet implementation. Edge cases came up especially with the snake casing and kwargs that I would prefer not to repeat.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I haven't been very consistent so far but most have followed the puppeteer API, but with snake casing and using kwargs insteads of options dicts. We should clean this up and decide whether to
cc @spulec @annieholladay @psarma89
The text was updated successfully, but these errors were encountered: