Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should_not_sample_route and should_not_sample_path should not override X-B3-Sampled #103

Open
drolando opened this issue Dec 21, 2018 · 0 comments

Comments

@drolando
Copy link
Contributor

With the current logic paths and routes that are blacklisted won't generate a span (and actually interrupt the trace at that point) even if the trace is being sampled. Imo that's not what we usually want.

We usually blacklist paths like /status, /swagger.json or /status/metrics. We do that because we don't want healthchecks and other automated calls to be traced.
But imo if we're in the middle of a trace I'm interested to know if my code is calling the status endpoint of another service and spending time on that.

@adriancole @bplotnick thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant